You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:20:08 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

ijuma commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r436792477



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2237,7 +2209,11 @@ class Log(@volatile private var _dir: File,
     def deleteSegments(): Unit = {
       info(s"Deleting segments ${segments.mkString(",")}")
       maybeHandleIOException(s"Error while deleting segments for $topicPartition in dir ${dir.getParent}") {
-        segments.foreach(_.deleteIfExists())
+        segments.foreach {
+          case segment =>

Review comment:
       Nit: `case` and newline are unnecessary here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org