You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "atiaomar1978-hub (via GitHub)" <gi...@apache.org> on 2026/08/02 12:13:46 UTC

Re: [PR] CAMEL-24275: Native Google Gemini API for Camel JBang TUI [camel]

atiaomar1978-hub commented on PR #25172:
URL: https://github.com/apache/camel/pull/25172#issuecomment-5157764413

   _AI-generated comment on behalf of [atiaomar1978-hub](https://github.com/atiaomar1978-hub)_
   
   ### Review follow-up (`84e886d2a68`)
   
   Addressed remaining feedback after the watsonx merge onto `main`:
   
   **@davsclaus** — prior inline items were already fixed in `8f8e53c7493` / rebase (`GEMINI_API_KEY`-only Doctor auto-detect, removed `GOOGLE_API_KEY` from TUI hints, dead Gemini query-param auth removed). This push adds the missing **watsonx.ai** alignment in `DoctorPopup.checkAiProvider()` so Doctor matches `LlmClient` auto-detect order (… → Gemini → OpenAI → **watsonx** → Ollama).
   
   **@gnodet** — applied minor nits:
   - `text.length() > 0` → `!text.isEmpty()` in Gemini response parsing
   - Doctor hint now includes `WATSONX_APIKEY` (consistent with `AiPanel`)
   
   **Local tests:** `LlmClientGeminiTest`, `LlmClientWatsonxTest`, `AiProviderSelectorTest` — all green.
   
   Ready for another CI run on the latest commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org