You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "YaziLee (via GitHub)" <gi...@apache.org> on 2024/03/12 02:12:41 UTC
[PR] [INLONG-9795][Sort] Regarding the format optimization of the data typ… [inlong]
YaziLee opened a new pull request, #9796:
URL: https://github.com/apache/inlong/pull/9796
…e enumeration definition of the Redis connector project module.
### Prepare a Pull Request
- Title Example: [INLONG-9795][Sort] Regarding the format optimization of the data typ…
- Fixes #9795
### Motivation
The current enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType is defined as,
; symbol ends. Although there is no grammatical problem with this, the code looks confusing, so it is recommended to modify it and remove it.
; symbol and add ";" that makes the code look clearer.
### Modifications
Removed the trailing symbol "" of the enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType,
;".
### Verifying this change
None
### Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9795][Sort] Regarding the format optimization of the data type definition [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #9796:
URL: https://github.com/apache/inlong/pull/9796#issuecomment-1989890168
close since duplciated #9764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9795][Sort] Regarding the format optimization of the data type definition [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #9796:
URL: https://github.com/apache/inlong/pull/9796#issuecomment-1989886239
Hi @YaziLee,
I think you're trying to resolve the comment https://github.com/apache/inlong/pull/9764#discussion_r1520684208.
It's better to resolve it in the original pull request(#9764 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9795][Sort] Regarding the format optimization of the data type definition [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #9796:
URL: https://github.com/apache/inlong/pull/9796#issuecomment-1989875871
duplicated pull request with #9764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9795][Sort] Regarding the format optimization of the data typ… [inlong]
Posted by "baomingyu (via GitHub)" <gi...@apache.org>.
baomingyu commented on PR #9796:
URL: https://github.com/apache/inlong/pull/9796#issuecomment-1989839243
> …e enumeration definition of the Redis connector project module.
>
> ### Prepare a Pull Request
> * Title Example: [INLONG-9795][Sort] Regarding the format optimization of the data typ…
> * Fixes [[Improve][Sort] Regarding the format optimization of the data type enumeration definition of the Redis connector project module. #9795](https://github.com/apache/inlong/issues/9795)
>
> ### Motivation
> The current enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType is defined as, ; symbol ends. Although there is no grammatical problem with this, the code looks confusing, so it is recommended to modify it and remove it. ; symbol and add ";" that makes the code look clearer.
>
> ### Modifications
> Removed the trailing symbol "" of the enumeration class org.apache.inlong.sort.redis.common.config.RedisDataType, ;".
>
> ### Verifying this change
> None
>
> ### Documentation
> * Does this pull request introduce a new feature? (yes / no) no
> * If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
> * If a feature is not applicable for documentation, explain why?
> * If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
Modify title please!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9795][Sort] Regarding the format optimization of the data type definition [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang closed pull request #9796: [INLONG-9795][Sort] Regarding the format optimization of the data type definition
URL: https://github.com/apache/inlong/pull/9796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org