You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/01/31 11:50:43 UTC
[PR] Allow to run ds-memory 3.0 on Java 25 [datasketches-memory]
pan3793 opened a new pull request, #271:
URL: https://github.com/apache/datasketches-memory/pull/271
This PR relaxes runtime Java version check - add Java 25 to the allow list, for `datasketches-memory` 4.0.
I understand that Java 17/21/25 is not supported by datasketches-memory 3.0.2, but I'd like to run it in limited mode with Java 25, as it does on Java 17/21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Allow to run ds-memory 3.0 on Java 25 [datasketches-memory]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #271:
URL: https://github.com/apache/datasketches-memory/pull/271#issuecomment-3842370339
@leerho, could you please take a look? thank you in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Allow to run ds-memory 3.0 on Java 25 [datasketches-memory]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on PR #271:
URL: https://github.com/apache/datasketches-memory/pull/271#issuecomment-3849462933
I have been thinking about your request and looked at your code and found a few more things that needed to be fixed. So instead of this PR, I have submitted a different PR #272, that adds a warning so that users attempting to run this code with Java versions > 11 will get a warning that no off-heap operations can be used. As you can see, if you look at 272, I found a bunch of checkstyle warnings that needed to be fixed as well.
Since 272 supersedes this one, I will close this one.
Thank you for your suggestions on this. Please thoroughly test the new _prepare_3.0.3_ branch form 272 in your environment to make sure it works with 25 like you expect. Do not expect it to pass tests with Java versions > 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Allow to run ds-memory 3.0 on Java 25 [datasketches-memory]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho closed pull request #271: Allow to run ds-memory 3.0 on Java 25
URL: https://github.com/apache/datasketches-memory/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org