You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/28 18:47:33 UTC

[GitHub] [tvm] tqchen commented on pull request #9980: [VirtualMachine] fix raw pointer using by VirtualMachine

tqchen commented on pull request #9980:
URL: https://github.com/apache/tvm/pull/9980#issuecomment-1024509306


   @vvchernov would be great if you can confirm my latest comment, which should be a better fix
   
   ```
   Sorry for the delayed reply. sptr_to_self actually is guanranteed to point to this in this particular case. So actually GetObjectPtr<Executable>(...) should work in this case. This is mainly because ObjectPtr is an intrusive pointer that directly leverages the object data structure.
   
   To confirm, we can add ICHECK(sptr_to_self.get() == this);
   ``


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org