You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org> on 2011/02/18 18:29:38 UTC
[jira] Created: (TRINIDAD-2039) Icons are created if the string for
the resource is an empty string in Trinidad 1.2
Icons are created if the string for the resource is an empty string in Trinidad 1.2
-----------------------------------------------------------------------------------
Key: TRINIDAD-2039
URL: https://issues.apache.org/jira/browse/TRINIDAD-2039
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 1.2.15-core
Reporter: Andrew Robinson
Assignee: Andrew Robinson
The toResourceUri in CoreRenderer returns null for a "" value in Trinidad 2 but not in Trinidad 1.2. What happens is that icons that may evaluate to blank strings (like EL bound icon attributes) may end up rendering a <img src=""> tag in Trinidad 1.2. This results in an extra call to the server in at least some browsers.
We should backport the fix from Trinidad 2 to 1.2 to prevent this from happening.
Issue can be reproduced easily with this code:
<tr:commandButton id="search" text="Search" icon="" action="search"/>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (TRINIDAD-2039) Icons are created if the string
for the resource is an empty string in Trinidad 1.2
Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Robinson resolved TRINIDAD-2039.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.15-core
> Icons are created if the string for the resource is an empty string in Trinidad 1.2
> -----------------------------------------------------------------------------------
>
> Key: TRINIDAD-2039
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2039
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.15-core
> Reporter: Andrew Robinson
> Assignee: Andrew Robinson
> Priority: Minor
> Fix For: 1.2.15-core
>
>
> The toResourceUri in CoreRenderer returns null for a "" value in Trinidad 2 but not in Trinidad 1.2. What happens is that icons that may evaluate to blank strings (like EL bound icon attributes) may end up rendering a <img src=""> tag in Trinidad 1.2. This results in an extra call to the server in at least some browsers.
> We should backport the fix from Trinidad 2 to 1.2 to prevent this from happening.
> Issue can be reproduced easily with this code:
> <tr:commandButton id="search" text="Search" icon="" action="search"/>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira