You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/11/23 02:51:15 UTC
[GitHub] zeppelin pull request #1670: [ZEPPELIN-1700] ConnectException between Zeppel...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1670
[ZEPPELIN-1700] ConnectException between ZeppelinServer and RemoteInterpreterProcess.
### What is this PR for?
The default value of interpreter connection timeout is 30s but sometimes 30 seconds may be insufficient to connect to RemoteInterpreterProcess.
I think to increase the timeout value doesn't effect of performance so it's okay to give large value.
and in the later, It's better give users to be able to edit Zeppelin Configurations on the web.
### What type of PR is it?
Bug Fix | Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1700
### Screenshots (if appropriate)
- before
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1700
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1670
----
commit 9ea612d7b2909074043ae0a577b687a09ea35260
Author: astroshim <hs...@nflabs.com>
Date: 2016-11-23T02:16:12Z
increase the interpreter connection timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1670: [ZEPPELIN-1700] ConnectException between Zeppel...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1670: [ZEPPELIN-1700] ConnectException between ZeppelinServe...
Posted by jpgbus <gi...@git.apache.org>.
Github user jpgbus commented on the issue:
https://github.com/apache/zeppelin/pull/1670
@Leemoonsoo Hats off to you and the community for Zeppelin - it seems to be a masterpiece in the making. I'd like to update the document for this ConfVars.
https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L576
`ZEPPELIN_INTERPRETER_CONNECT_TIMEOUT("zeppelin.interpreter.connect.timeout", 30000),`
I submitted [PR](https://github.com/apache/zeppelin/pull/1993)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1670: [ZEPPELIN-1700] ConnectException between ZeppelinServe...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1670
@astroshim Thanks for the contribution.
Could you edit default value from [here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L557) instead of multiplying timeout value when reading it?
Although it's not configurable through the web, `ZEPPELIN_INTERPRETER_CONNECT_TIMEOUT` is already configurable through conf/zeppelin-env.sh or conf/zeppelin-site.xml.
So some unusual case that requires very long process startup time will still able to configure the timeout.
So i would suggest some reasonable time for the default timeout. 5min (30s*10) is too large IMO. Maybe a minute?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1670: [ZEPPELIN-1700] ConnectException between ZeppelinServe...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1670
@Leemoonsoo Oh sorry, I didn't know that the value is configurable.
If modification is possible, It's better to close this PR because 30s is okay in normal case.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---