You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2025/04/17 13:03:01 UTC

[PR] IGNITE-25180 Fix race between drop index and partition garbage collection [ignite-3]

tkalkirill opened a new pull request, #5661:
URL: https://github.com/apache/ignite-3/pull/5661

   https://issues.apache.org/jira/browse/IGNITE-25180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-25180 Fix race between drop index and partition garbage collection [ignite-3]

Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #5661:
URL: https://github.com/apache/ignite-3/pull/5661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-25180 Fix race between drop index and partition garbage collection [ignite-3]

Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #5661:
URL: https://github.com/apache/ignite-3/pull/5661#discussion_r2048997233


##########
modules/table/src/main/java/org/apache/ignite/internal/table/TableImpl.java:
##########
@@ -231,15 +231,18 @@ public <K> int partitionId(K key, Mapper<K> keyMapper) {
     }
 
     /** Returns a supplier of index storage wrapper factories for given partition. */
-    public TableIndexStoragesSupplier indexStorageAdapters(int partId) {
+    public TableIndexStoragesSupplier indexStorageAdapters(int partitionId) {
         return () -> {
-            List<IndexWrapper> factories = new ArrayList<>(indexWrapperById.values());
+            var factories = new ArrayList<>(indexWrapperById.values());

Review Comment:
   I'll leave it as is, the idea suggests that the type can be removed and makes it gray.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org