[GitHub] [pinot] dd-willgan commented on a diff in pull request #10785: [WIP] allow env var substibution for Pinot configs

["dd-willgan (via GitHub)" <gi...@apache.org>]

dd-willgan commented on code in PR #10785:
URL: https://github.com/apache/pinot/pull/10785#discussion_r1199344351


##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##########
@@ -357,6 +358,9 @@ public long getProperty(String name, long defaultValue) {
    */
   public String getProperty(String name, String defaultValue) {
     Object rawProperty = getRawProperty(name, defaultValue);

Review Comment:
   For this couldn't we check if the property key exists and if not use defaultValue, otherwise just have the same logic as getProperty(String name, Configuration configuration)? That would handle the multi-value case I think 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org