You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Joy Gao (JIRA)" <ji...@apache.org> on 2018/03/12 18:06:00 UTC
[jira] [Resolved] (AIRFLOW-2207) Fix flaky test that uses
app.cached_app()
[ https://issues.apache.org/jira/browse/AIRFLOW-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joy Gao resolved AIRFLOW-2207.
------------------------------
Resolution: Fixed
Fix Version/s: 1.10.0
Issue resolved by pull request #3123
[https://github.com/apache/incubator-airflow/pull/3123]
> Fix flaky test that uses app.cached_app()
> -----------------------------------------
>
> Key: AIRFLOW-2207
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2207
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Minor
> Fix For: 1.10.0
>
>
> tests.www.test_views:TestMountPoint.test_mount changes base_url then calls airflow.www.app.cached_app().
> But if another test calls app.cached_app() first without changing base_url, succeeding test_mount fails on Travis.
> For example, adding the following test causes test_mount to fail,
> whereas test_dummy itself succeeds:
> {code}
> class TestDummy(unittest.TestCase):
> def setUp(self):
> super(TestDummy, self).setUp()
> configuration.load_test_config()
> app = application.cached_app(testing=True)
> self.client = Client(app)
> def test_dummy(self):
> response, _, _ = self.client.get('/', follow_redirects=True)
> resp_html = b''.join(response)
> self.assertIn(b"DAGs", resp_html)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)