You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "ltamber (via GitHub)" <gi...@apache.org> on 2024/12/02 06:30:15 UTC

Re: [PR] [ISSUE #9002]when bytebuffer is not enough, do not throw exception [rocketmq]

ltamber commented on code in PR #9003:
URL: https://github.com/apache/rocketmq/pull/9003#discussion_r1865288938


##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########


Review Comment:
   Sorry, I don't quite understand, I see that there's a catch block in the code below, so there shouldn't be any exception thrown, right?https://github.com/apache/rocketmq/blob/9a891f1d49af0cfe4e384bc28a0bf0eeed02587f/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L630-L631



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org