You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/09 08:41:42 UTC
[GitHub] [pulsar] equanz opened a new pull request, #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
equanz opened a new pull request, #15502:
URL: https://github.com/apache/pulsar/pull/15502
Fixes #15471
### Motivation
Please see https://github.com/apache/pulsar/issues/15471 .
### Modifications
* if producerName is null, then fall back to `supportsPartialProducer=false`
- currently, producerName is required when`supportsPartialProducer=true`, because stats are aggregated by producerName
* allow null producerName on getPublishers
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
* Add tests for null producerName
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `no-need-doc`
This PR is one of the fixing issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] equanz commented on pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
equanz commented on PR #15502:
URL: https://github.com/apache/pulsar/pull/15502#issuecomment-1124555787
> I think the root cause is here :
Yes. I think so too.
> We should set producerName for the newStats
I think we can't set producerName in this section, because old client's partitioned producer can have different producerName between internal producers. https://github.com/apache/pulsar/pull/12401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
URL: https://github.com/apache/pulsar/pull/15502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #15502:
URL: https://github.com/apache/pulsar/pull/15502#issuecomment-1122374761
I think the root cause is here :
https://github.com/apache/pulsar/blob/ca614e0fcc87b751204a97a081c7f00545b3f87b/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/TopicStatsImpl.java#L234-L238
We should set `producerName` for the `newStats `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] equanz commented on pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
equanz commented on PR #15502:
URL: https://github.com/apache/pulsar/pull/15502#issuecomment-1121781459
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #15502:
URL: https://github.com/apache/pulsar/pull/15502#issuecomment-1122365148
> Why the produceName is null?
Get it from the issue comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #15502:
URL: https://github.com/apache/pulsar/pull/15502#issuecomment-1122360929
Why the produceName is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #15502:
URL: https://github.com/apache/pulsar/pull/15502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #15502: [fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #15502:
URL: https://github.com/apache/pulsar/pull/15502#issuecomment-1124559018
> > I think the root cause is here :
>
> Yes. I think so too.
>
> > We should set producerName for the newStats
>
> I think we can't set producerName in this section, because old client's partitioned producer can have different producerName between internal producers. #12401
Ok, make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org