You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2019/12/28 23:43:22 UTC
[GitHub] [incubator-nuttx] wingunder opened a new pull request #14: Fixed
includes in arch/arm/src/stm32l4/hardware/.
wingunder opened a new pull request #14: Fixed includes in arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14
Several header files in arch/arm/src/stm32l4/hardware/ had the
following line included:
#include "chip.h"
The problem with this was that the chip.h file is missing in this
directory (in arch/arm/src/stm32l4/hardware/). The intended chip.h
file to include was probably in arch/arm/src/stm32l4/chip.h. If any of
the headers in arch/arm/src/stm32l4/hardware/ got included from a
directory that did not contain a chip.h file, the compilation
failed.
After looking deeper into this I realized that the following files
were also including files with the wrong paths:
- arch/arm/src/stm32l4/hardware/stm32l4_syscfg.h
- arch/arm/src/stm32l4/hardware/stm32l4_pinmap.h
Finally, it seems as if a lot of headers, but not all, included:
#include <nuttx/config.h>
In this case, the include is only useful if a CONFIG_* define is
being referenced. These includes were removed from files that had no
CONFIG_* references and added to files that had CONFIG_* references,
but was missing the include.
The final change to be mentioned, was the moving of the GPIO defines
from arch/arm/src/stm32l4/stm32l4_gpio.h to
arch/arm/src/stm32l4/hardware/stm32l4_gpio.h. This was done to supply
arch/arm/src/stm32l4/hardware/stm32l4*_pinmap.h with a local include
for their GPIO references.
This patch changes no functionality. It simply cleans up includes and
allows inclusion of the headers in arch/arm/src/stm32l4/hardware/
from anywhere, without causing compiler errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo closed pull request #14: Fixed includes
in arch/arm/src/stm32l4/hardware/.
Posted by GitBox <gi...@apache.org>.
patacongo closed pull request #14: Fixed includes in arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] wingunder commented on issue #14: Fixed includes
in arch/arm/src/stm32l4/hardware/.
Posted by GitBox <gi...@apache.org>.
wingunder commented on issue #14: Fixed includes in arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14#issuecomment-570303541
Hi @patacongo & @acassis,
Thank you for you feedback. I accept your reasoning.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #14: Fixed includes in
arch/arm/src/stm32l4/hardware/.
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #14: Fixed includes in arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14#issuecomment-570075877
Hi wingunder, please note that normally header files included inside stm32l4/hardware/ directory are mainly used for internal chip registers definitions and the headers at base of stm324/ contains definitions that will be outside of arch/ dir i.e. inside boards/ . Also note that all arch follow this logic, if you want to change it you need to do it for all arch, not only for stm32l4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #14: Fixed includes
in arch/arm/src/stm32l4/hardware/.
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #14: Fixed includes in arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14#issuecomment-570074562
I don't believe this change should be incorporated upstream. It does not handle the include paths and it takes perfectly compliant code and makes it inconsistent with everyother architecute. Consistency must be preserved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services