You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by lw-lin <gi...@git.apache.org> on 2016/09/20 06:37:40 UTC

[GitHub] flink pull request #2515: [FLINK-4638] Fix exception message for MemorySegme...

GitHub user lw-lin opened a pull request:

    https://github.com/apache/flink/pull/2515

    [FLINK-4638] Fix exception message for MemorySegment

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lw-lin/flink fix-msg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2515
    
----
commit 825576c518e83898beaee16ebe304201432ce425
Author: Liwei Lin <lw...@gmail.com>
Date:   2016-09-20T06:35:28Z

    [FLINK-4638] Fix exception message for MemorySegment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2515: [FLINK-4638] [core] Fix exception message for Memo...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2515


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2515: [FLINK-4638] [core] Fix exception message for MemorySegme...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/2515
  
    Thanks for reporting and fixing! Merging ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2515: [FLINK-4638] Fix exception message for MemorySegme...

Posted by lw-lin <gi...@git.apache.org>.

Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2515#discussion_r79544108
  
    --- Diff: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java ---
    @@ -161,7 +161,7 @@
     		}
     		if (offHeapAddress >= Long.MAX_VALUE - Integer.MAX_VALUE) {
     			// this is necessary to make sure the collapsed checks are safe against numeric overflows
    -			throw new IllegalArgumentException("Segment initialized with too large address: " + address
    --- End diff --
    
    here `address` has not been initialized yet; should really be `offHeapAddress`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---