You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2020/12/18 00:17:50 UTC
svn commit: r1884581 - /poi/trunk/src/java/org/apache/poi/util/POILogger.java
Author: fanningpj
Date: Fri Dec 18 00:17:50 2020
New Revision: 1884581
URL: http://svn.apache.org/viewvc?rev=1884581&view=rev
Log:
avoid string concats
Modified:
poi/trunk/src/java/org/apache/poi/util/POILogger.java
Modified: poi/trunk/src/java/org/apache/poi/util/POILogger.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/POILogger.java?rev=1884581&r1=1884580&r2=1884581&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/POILogger.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/POILogger.java Fri Dec 18 00:17:50 2020
@@ -96,17 +96,26 @@ public interface POILogger {
*/
default void log(int level, Object... objs) {
if (!check(level)) return;
- StringBuilder sb = new StringBuilder(32);
Throwable lastEx = null;
- for (int i=0; i<objs.length; i++) {
- if (i == objs.length-1 && objs[i] instanceof Throwable) {
- lastEx = (Throwable)objs[i];
- } else {
- sb.append(objs[i]);
+ String msg;
+ if (objs.length == 0) {
+ msg = "";
+ } else if (objs.length == 1) {
+ if (objs[0] instanceof Throwable) {
+ lastEx = (Throwable)objs[0];
}
+ msg = objs[0].toString();
+ } else {
+ StringBuilder sb = new StringBuilder(32);
+ for (int i=0; i<objs.length; i++) {
+ if (i == objs.length-1 && objs[i] instanceof Throwable) {
+ lastEx = (Throwable)objs[i];
+ } else {
+ sb.append(objs[i]);
+ }
+ }
+ msg = sb.toString();
}
-
- String msg = sb.toString();
// log forging escape
msg = msg.replaceAll("[\r\n]+", " ");
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org