You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/19 13:41:32 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4276: ListAll including VMs in projects for ADMIN
GabrielBrascher opened a new pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276
## Description
<!--- Describe your changes in detail -->
Recently I opened issue #4267 to understand if it is possible to list all VMs, including those on Projects. Thanks to @rhtyd, I learned that there is a way of listing when `listall=true` and `projectid=-1`.
However, looking into the [listVirtualMachines API command documentation](https://cloudstack.apache.org/api/apidocs-4.14/apis/listVirtualMachines.html) there is the following description:
> listall: If set to false, list only resources belonging to the command's caller; if set to true - list resources that the caller is authorized to see. Default value is false
The documentation is clear about the fact that when parameter `listall=true` then `listVirtualMachines` lists resources that the caller is authorized to see. Therefore, this PR considers that the ADMIN is _authorized to see_ all VMs, including those on projects.
Fixes: #4267
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
I tested it via CloudMonkey and CloudStack UI. CloudMonkey output example:
```
cmk > list virtualmachines filter=id,account,project,name,state listall=true
id account project name state
86ba5f14-b783-4e66-b511-ba617ca88d38 gabriel VM-86ba5f14-b783-4e66-b511-ba617ca88d38 Running
717f2e13-c207-4861-af0a-619ba1552f57 admin test-02 Running
c15f35aa-2343-47c3-9d57-36b3ba16d885 gabriel VM-c15f35aa-2343-47c3-9d57-36b3ba16d885 Running
1b1047ed-8c29-40f5-bd2d-cd979adc668d admin ha-01-shared Running
da787937-e3aa-409b-97b2-36ba4c45eb67 gabriel VM-da787937-e3aa-409b-97b2-36ba4c45eb67 Running
a40b8e98-29c7-4bf4-8209-2563d9c3db48 testproject test-01 Running
ca76ff8c-36f7-4183-b984-513106391db3 gabriel VM-ca76ff8c-36f7-4183-b984-513106391db3 Running
1f6b4fc6-f44f-4084-8ddd-14b916ada345 gabriel VM-1f6b4fc6-f44f-4084-8ddd-14b916ada345 Running
e17b9817-bea1-4b98-a153-7b272ff99745 gabriel VM-e17b9817-bea1-4b98-a153-7b272ff99745 Running
75b2e67e-2bda-4a55-b84a-91e69476a893 gabriel VM-75b2e67e-2bda-4a55-b84a-91e69476a893 Running
4a226a80-8899-4ea7-80ea-220667c2b46d gabriel VM-4a226a80-8899-4ea7-80ea-220667c2b46d Running
eebb96fd-7320-4f91-8881-3c75aff9e9cc testproject vm-on-project01 Running
50215261-dbcb-47d7-bb3b-5e7626f1379f admin test-00 Running
7d314232-0c60-4b1f-89b6-e63626134628 admin test-u18-p3 Running
31f087dc-622a-412c-97cf-7e38d51643d0 admin tiny-py3 Running
54aa67ab-d106-47f8-8e3c-26a2496828d8 admin test-vr-py3 Running
85b3b81b-7ce4-4087-b791-a7e92f0c365c admin medium-local Running
701c73fb-35a1-4840-8db6-c90d41b95601 testproject vm-project-02 Running
38a2cfa3-02ba-44bb-92c6-6c5a32e38aa9 gabriel VM-38a2cfa3-02ba-44bb-92c6-6c5a32e38aa9 Running
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-725271104
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-937905076
@rhtyd I've tested it with the new UI and this would require changes in the UI as well, as it would be listing all VMs including from projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-993187818
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919193573
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919383613
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-937927814
So the API has a squiffy name, I think there are bigger things to worry about.
At worse add the info to the API description.
projectid=-1 gives the functional output required.
Why are we trying to change an API that isn't really broken, at the risk of unintended consequences?
Put an include 'projects' toggle on the UI - default it to 'on' if you like - and jobs done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-729146330
@GabrielBrascher can you have a look at #4469 and see if this is still needed or needs adjusting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-878202144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-938022984
@rhtyd @PaulAngus @wido @nvazquez updated this PR to address just the API documentation changes in order to address with a safer option.
In the medium-long term we might (or not) get back at changing this API implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713517807
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713517807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-712863171
Packaging result: ✖centos7 ✖centos8 ✔debian. JID-2227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713635778
> @rhtyd @RodrigoDLopez @wido do this get your LGTMs?
Hi @DaanHoogland
I agree with this approuch
Code LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713548717
@rhtyd @RodrigoDLopez @wido do this get your LGTMs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-937138524
@nvazquez PR #4828 looks to be focused o the UI. This one proposes changes to the API and the scenario that this came was when calling the API; so the UI was not a target here.
@rhtyd I will build and check the UI with this patch soon(ish).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919384022
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-990761875
@rhtyd no problem in having this at 4.17.0.0.
This PR initially proposed changing the API, but later, after the feedback, I changed the scope to updating API documentation.; thus, ensuring that the `projectid=-1` option is explicit and clear in the API documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-712863171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713349502
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919237302
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-712791297
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-921994364
@rhtyd I will double-check this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-993193535
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-680228767
@rhtyd I understand your point. However, I think that either the documentation is incomplete or the `listAll=true` does not match with the documented/expected behavior.
Regarding the UI, I think that adding a toggle slider/radio in Primate would be nice indeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-918848227
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713372299
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-731207641
I think changing for all list APIs makes the most sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-979153747
@GabrielBrascher changed the milestone based on base `main` branch, if this is 4.16 pl fix PR base branch and advise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4276: Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-993166563
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713777690
> > We need to update the changelog properly though
>
> what exactly do you have in mind?
We need to mention something like:
<pre>The listAll parameter of listVirtualMachines now also lists all Instances which are under a project. Previously these would only be returned when *projectid=-1* was supplied as a parameter</pre>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713729678
> We need to update the changelog properly though
what exactly do you have in mind?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-712791708
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-937905076
@rhtyd I've tested it with the new UI and this would require changes in the UI as well, as it would be listing all VMs including from projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-925773377
@GabrielBrascher maybe this can be solved by PR https://github.com/apache/cloudstack/pull/4828?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-993167170
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-724950912
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919030518
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919759979
LGTM - but this may break something in UI, for example in UI listall=true is passed; so as a root admin user/account you'll be now able to see all VMs across all projects; and some actions may require the passing of projectid when doing some operation with resources owned by a project. A failure case may be, in UI we see all VMs, and root admin selects a VM that belongs to a project and tries to say attach a volume or network to the VM that doesn't belong to the project -> some error/exception/security issue could be caused. Maybe I'm overthinking, @GabrielBrascher can you explore in this direction and advise if this could cause any regression in UI or operation issue like I've described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919195671
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-924057485
@GabrielBrascher please advise after your checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-712791297
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-701938258
@rhtyd The documentation currently states otherwise. The 'listall' parameter should now be called: 'listallexceptinstancesinprojects'
This seems like an oversight during implementation (a bug) rather then a feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-878202443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713549036
cc @svenvogel ^^?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-731204271
> @GabrielBrascher while it does make sense to do this to comply with what the documentation states wrt listall parameter, wouldn't it require us to handle this scenario for all resources owned by projects for the sake of consistency. Otherwise it may possibly lead to ambiguity when we list VMs with listall set to true vs listing say networks with listall=true.
Yes, we probably want to double check that. But it's good that we have this discussion. As right now it's difficult for an Admin to find all resources when they are in a project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-725557966
<b>Trillian test result (tid-3147)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32018 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4276-t3147-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesSupportedVersion>:setup | `Error` | 0.00 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713517474
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713540417
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-878707133
<b>Trillian test result (tid-1235)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45301 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4276-t1235-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 341.95 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 342.18 | test_routers_network_ops.py
test_02_redundant_VPC_default_routes | `Failure` | 348.19 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 471.81 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-724982705
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713678018
I am LGTM with this. 'listAll' should do as it implies: List all Virtual Machines
We need to update the changelog properly though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-731191201
@Pearl1594 I agree, as far as I know all the list calls that have `listall` parameters (e.g. `listVOlumes`, `listTemplates`, `listNetworks`) describe `listall` in the same way.
Either we change the documentation of them all, or we allow them to return all resources of the respective owner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713517474
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-937905076
@rhtyd I've tested it with the new UI and this would require changes in the UI as well, as it would be listing all VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-937927814
So the API has a squiffy name, I think there are bigger things to worry about.
At worse add the info to the API description.
projectid=-1 gives the functional output required.
Why are we trying to change an API that isn't really broken, at the risk of unintended consequences?
Put an include 'projects' toggle on the UI - default it to 'on' if you like - and jobs done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919247862
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-993632320
<b>Trillian test result (tid-2655)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30342 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4276-t2655-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #4276: Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects.
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-729155984
@DaanHoogland PR #4469 regards listing projects, correct?
This PR is different, altering the `listVirtualMachines` command result in order to include all VMs from projects as well when the admin lists VMs with `listall=true`. The motivation is due to the API command `listAll` description: https://cloudstack.apache.org/api/apidocs-4.14/apis/listVirtualMachines.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-731020372
@GabrielBrascher while it does make sense to do this to comply with what the documentation states wrt listall parameter, wouldn't it require us to handle this scenario for all resources owned by projects for the sake of consistency. Otherwise it may possibly lead to ambiguity when we list VMs with listall set to true vs listing networks with listall=true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-724951283
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713350034
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-725271422
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-676413698
I think what you're trying to do is OK but could potentially break the listAPI for some environment. If you want we can show a toggle slider/radio in Primate list view which when checked can send the list VM API with listall=true and projectid=-1 which effectively would show the expected output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919675509
<b>Trillian test result (tid-2044)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33603 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4276-t2044-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-713349502
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-937138524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-918847825
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-731137972
As @Pearl1594 raised a valid concern here I am moving this to 4.16 for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #4276: ListAll including VMs in projects for ADMIN
Posted by GitBox <gi...@apache.org>.
Pearl1594 edited a comment on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-731020372
@GabrielBrascher while it does make sense to do this to comply with what the documentation states wrt listall parameter, wouldn't it require us to handle this scenario for all resources owned by projects for the sake of consistency. Otherwise it may possibly lead to ambiguity when we list VMs with listall set to true vs listing say networks with listall=true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4276: Update listVirtualMachines API documentation with 'projectid=-1' to list all VMs in projects.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4276:
URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-993192645
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org