You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/02/16 13:29:23 UTC
Review Request 56750: Don't rerender all widgets when on of them is
changed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56750/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: ambari-20043
https://issues.apache.org/jira/browse/ambari-20043
Repository: ambari
Description
-------
Dashboard widgets are rerendered if some of them is changed. Actually only this one should be updated and not other
Diffs
-----
ambari-web/app/assets/test/tests.js d47d558
ambari-web/app/data/dashboard_widgets.js PRE-CREATION
ambari-web/app/messages.js 81833f3
ambari-web/app/mixins/common/track_request_mixin.js 4efcecb
ambari-web/app/mixins/main/dashboard/widgets/editable.js fcb6bfb
ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js ddf2a26
ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 06bcffe
ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 7caf085
ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 86ffb47
ambari-web/app/views.js 77b5d5a
ambari-web/app/views/common/modal_popups/edit_dashboard_widget_popup.js PRE-CREATION
ambari-web/app/views/main/dashboard/widget.js e7a626c
ambari-web/app/views/main/dashboard/widgets.js 572625d
ambari-web/app/views/main/dashboard/widgets/text_widget.js daa354c
ambari-web/test/views/common/modal_popups/edit_dashboard_widget_popup_test.js PRE-CREATION
ambari-web/test/views/main/dashboard/widget_test.js a504c6d
ambari-web/test/views/main/dashboard/widgets_test.js 5d1ddb2
Diff: https://reviews.apache.org/r/56750/diff/
Testing
-------
20372 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 56750: Don't rerender all widgets when on of them
is changed
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56750/#review165841
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Feb. 16, 2017, 1:29 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56750/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 1:29 p.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20043
> https://issues.apache.org/jira/browse/ambari-20043
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Dashboard widgets are rerendered if some of them is changed. Actually only this one should be updated and not other
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js d47d558
> ambari-web/app/data/dashboard_widgets.js PRE-CREATION
> ambari-web/app/messages.js 81833f3
> ambari-web/app/mixins/common/track_request_mixin.js 4efcecb
> ambari-web/app/mixins/main/dashboard/widgets/editable.js fcb6bfb
> ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js ddf2a26
> ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 06bcffe
> ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 7caf085
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 86ffb47
> ambari-web/app/views.js 77b5d5a
> ambari-web/app/views/common/modal_popups/edit_dashboard_widget_popup.js PRE-CREATION
> ambari-web/app/views/main/dashboard/widget.js e7a626c
> ambari-web/app/views/main/dashboard/widgets.js 572625d
> ambari-web/app/views/main/dashboard/widgets/text_widget.js daa354c
> ambari-web/test/views/common/modal_popups/edit_dashboard_widget_popup_test.js PRE-CREATION
> ambari-web/test/views/main/dashboard/widget_test.js a504c6d
> ambari-web/test/views/main/dashboard/widgets_test.js 5d1ddb2
>
> Diff: https://reviews.apache.org/r/56750/diff/
>
>
> Testing
> -------
>
> 20372 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>