You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/01/23 22:25:12 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #22833: feat: Adds the ECharts Sunburst chart
michael-s-molina opened a new pull request, #22833:
URL: https://github.com/apache/superset/pull/22833
### SUMMARY
Completes the work made in https://github.com/apache/superset/pull/21625 to add the ECharts Sunburst chart.
- Adds a thumbnail and example pictures
- Adds a Storybook entry for the chart
- Fixes a bug with the dimension colors when using the secondary metric
- Makes the relationship between hierarchies and the circles clear to the user
- Uses the [callback function](https://echarts.apache.org/en/option.html#tooltip.formatter) and return an HTML element for the tooltip
- Improves the tooltip description to show the hierarchy names
- Improves tooltip positioning as it is sometimes being cut off the screen
- Fixes the calculation of total values
- Registers the chart again so it's available for use
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1166" alt="Screenshot 2023-01-23 at 5 10 49 PM" src="https://user-images.githubusercontent.com/70410625/214163134-87d4e6bb-62f0-489a-9ece-71aefb5ce28a.png">
### TESTING INSTRUCTIONS
- Check the plugin description in the chart viz control
- Create a Sunburst v2 chart
- Interact with the available controls in Explore
- Make sure all controls are working
- Check the plugin Storybook
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22833: feat: Adds the ECharts Sunburst chart
Posted by github-actions.
github-actions[bot] commented on PR #22833:
URL: https://github.com/apache/superset/pull/22833#issuecomment-1406963003
@rusackas Ephemeral environment spinning up at http://35.164.138.56:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22833: feat: Adds the ECharts Sunburst chart
Posted by codecov.
codecov[bot] commented on PR #22833:
URL: https://github.com/apache/superset/pull/22833#issuecomment-1402639518
# [Codecov](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22833](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b76a94) into [master](https://codecov.io/gh/apache/superset/commit/577ac81686a9bf2074320e2eeb84bfa4d5562822?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (577ac81) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #22833 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 1877 1877
Lines 71939 72000 +61
Branches 7877 7891 +14
=======================================
+ Hits 48412 48454 +42
- Misses 21499 21518 +19
Partials 2028 2028
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.88% <0.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...plugin-chart-echarts/src/Sunburst/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvY29udHJvbFBhbmVsLnRzeA==) | `28.57% <ø> (ø)` | |
| [...plugins/plugin-chart-echarts/src/Sunburst/index.ts](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvaW5kZXgudHM=) | `50.00% <ø> (+50.00%)` | :arrow_up: |
| [...lugin-chart-echarts/src/Sunburst/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/plugin-chart-echarts/src/defaults.ts](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvZGVmYXVsdHMudHM=) | `100.00% <ø> (+80.00%)` | :arrow_up: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `70.00% <0.00%> (-5.35%)` | :arrow_down: |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `46.60% <0.00%> (-3.40%)` | :arrow_down: |
| [...plore/components/controls/OptionControls/index.tsx](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9PcHRpb25Db250cm9scy9pbmRleC50c3g=) | `75.53% <0.00%> (-1.65%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.44% <0.00%> (-1.17%)` | :arrow_down: |
| [.../components/Header/HeaderActionsDropdown/index.jsx](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9IZWFkZXJBY3Rpb25zRHJvcGRvd24vaW5kZXguanN4) | `68.25% <0.00%> (-1.11%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/superset/pull/22833?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22833: feat: Adds the ECharts Sunburst chart
Posted by github-actions.
github-actions[bot] commented on PR #22833:
URL: https://github.com/apache/superset/pull/22833#issuecomment-1410710683
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22833: feat: Adds the ECharts Sunburst chart
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22833:
URL: https://github.com/apache/superset/pull/22833#issuecomment-1406960937
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #22833: feat: Adds the ECharts Sunburst chart
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #22833:
URL: https://github.com/apache/superset/pull/22833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org