[GitHub] [incubator-mxnet] roywei commented on issue #15525: Nightly tests / integration tests in PRs are not tested before merging

[GitBox <gi...@apache.org>]

roywei commented on issue #15525: Nightly tests / integration tests in PRs are not tested before merging
URL: https://github.com/apache/incubator-mxnet/issues/15525#issuecomment-510993342
 
 
   - Nightly tests are supposed to fail and we can revert whichever PR caused it, other wise it's too costly to run even for PR validation, imagine each commit will trigger a big job.
   - Most of the time, when contributors are changing nightly test configurations and adding nightly tests, they test it anyway, it's not likely to fail.
   - Test tuorials is a special case as many people are contributing to tutorials. But most of them don't know they have to add any dependency in CI and warnings are considered as failure. That's most of the reasons for CI failure.
   
   To start with, without any new features been added, maybe some way to enforce contributors to test tutorials locally before merging PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services