You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/06 03:30:09 UTC

[GitHub] [incubator-iotdb] vesense commented on a change in pull request #886: [IOTDB-545] Update checkPathValidity in Session

vesense commented on a change in pull request #886: [IOTDB-545] Update checkPathValidity in Session
URL: https://github.com/apache/incubator-iotdb/pull/886#discussion_r388696204
 
 

 ##########
 File path: session/src/main/java/org/apache/iotdb/session/Session.java
 ##########
 @@ -654,8 +648,7 @@ public void executeNonQueryStatement(String sql) throws TException, IoTDBRPCExce
   private void checkPathValidity(String path) throws IoTDBSessionException {
     if (!Pattern.matches(PATH_MATCHER, path)) {
 
 Review comment:
   If a pattern is to be used multiple times, compiling it once and reusing it will be more efficient than invoking this method each time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services