You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/21 19:02:00 UTC
[jira] [Commented] (SPARK-23078) Allow Submitting Spark Thrift
Server in Cluster Mode
[ https://issues.apache.org/jira/browse/SPARK-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726982#comment-16726982 ]
ASF GitHub Bot commented on SPARK-23078:
----------------------------------------
vanzin closed pull request #20272: [SPARK-23078] [CORE] [K8s] allow Spark Thrift Server to run in Kubernetes Cluster mode
URL: https://github.com/apache/spark/pull/20272
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala b/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
index 1e381965c52ba..71e33f231786a 100644
--- a/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
@@ -328,7 +328,7 @@ object SparkSubmit extends CommandLineUtils with Logging {
printErrorAndExit("Cluster deploy mode is not applicable to Spark shells.")
case (_, CLUSTER) if isSqlShell(args.mainClass) =>
printErrorAndExit("Cluster deploy mode is not applicable to Spark SQL shell.")
- case (_, CLUSTER) if isThriftServer(args.mainClass) =>
+ case (_, CLUSTER) if (clusterManager != KUBERNETES) && isThriftServer(args.mainClass) =>
printErrorAndExit("Cluster deploy mode is not applicable to Spark Thrift server.")
case _ =>
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Allow Submitting Spark Thrift Server in Cluster Mode
> ----------------------------------------------------
>
> Key: SPARK-23078
> URL: https://issues.apache.org/jira/browse/SPARK-23078
> Project: Spark
> Issue Type: Improvement
> Components: Kubernetes, Spark Submit, SQL
> Affects Versions: 2.2.0, 2.2.1, 2.3.0
> Reporter: Oz Ben-Ami
> Priority: Minor
>
> Since SPARK-5176, SparkSubmit has blacklisted the Thrift Server from running in Cluster mode, since at the time it was not able to do so successfully. I have confirmed that Spark Thrift Server can run on Cluster mode in Kubernetes, by commenting out [https://github.com/apache-spark-on-k8s/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L331.] I have not had a chance to test against YARN. Since Kubernetes does not have Client mode, this change is necessary to run Spark Thrift Service in Kubernetes.
> [~foxish] [~coderanger]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org