You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/05/18 07:16:11 UTC
[GitHub] [pulsar] tisonkun commented on a diff in pull request #20348: [fix][test] ProxyWithoutServiceDiscoveryTest should enable authz
tisonkun commented on code in PR #20348:
URL: https://github.com/apache/pulsar/pull/20348#discussion_r1197486595
##########
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithoutServiceDiscoveryTest.java:
##########
@@ -198,10 +196,10 @@ public void testDiscoveryService() throws Exception {
}
protected final PulsarClient createPulsarClient(Authentication auth, String lookupUrl) throws Exception {
- admin = spy(PulsarAdmin.builder().serviceHttpUrl(brokerUrlTls.toString()).tlsTrustCertsFilePath(TLS_TRUST_CERT_FILE_PATH)
- .allowTlsInsecureConnection(true).authentication(auth).build());
Review Comment:
Why remove `allowTlsInsecureConnection(true)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org