You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/11/07 17:01:09 UTC

Review Request 69263: Import Process: Clear RequestContext After Each Entity Create

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69263/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Bugs: ATLAS-2956
    https://issues.apache.org/jira/browse/ATLAS-2956


Repository: atlas


Description
-------

**Approach**
* Modified _BulkImportImpl_ to add _RequestContext_ clear at the end of each entity create.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 62b393afe 


Diff: https://reviews.apache.org/r/69263/diff/1/


Testing
-------

**Unit tests**
Executed existing tests.

**Functional tests**
Import via REST APIs.


Thanks,

Ashutosh Mestry


Re: Review Request 69263: Import Process: Clear RequestContext After Each Entity Create

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69263/#review210369
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Nov. 7, 2018, 9:06 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69263/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2018, 9:06 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2956
>     https://issues.apache.org/jira/browse/ATLAS-2956
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> * Modified _BulkImportImpl_ to add _RequestContext_ clear at the end of each entity create.
> 
> **Additional information**
> Fix already exists on master.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 62b393afe 
> 
> 
> Diff: https://reviews.apache.org/r/69263/diff/1/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> Executed existing tests.
> 
> **Functional tests**
> Import via REST APIs.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Re: Review Request 69263: Import Process: Clear RequestContext After Each Entity Create

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69263/
-----------------------------------------------------------

(Updated Nov. 7, 2018, 5:06 p.m.)


Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Changes
-------

Updates include: Added 'Additional information'.


Bugs: ATLAS-2956
    https://issues.apache.org/jira/browse/ATLAS-2956


Repository: atlas


Description (updated)
-------

**Approach**
* Modified _BulkImportImpl_ to add _RequestContext_ clear at the end of each entity create.

**Additional information**
Fix already exists on master.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 62b393afe 


Diff: https://reviews.apache.org/r/69263/diff/1/


Testing
-------

**Unit tests**
Executed existing tests.

**Functional tests**
Import via REST APIs.


Thanks,

Ashutosh Mestry