You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/07 12:47:24 UTC
[GitHub] [shardingsphere] longtai-cn opened a new pull request, #16642: Add an introductory article on ShardingSphere-Proxy
longtai-cn opened a new pull request, #16642:
URL: https://github.com/apache/shardingsphere/pull/16642
Changes proposed in this pull request:
- Add an introductory article on ShardingSphere-Proxy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #16642: Add an introductory article on ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #16642:
URL: https://github.com/apache/shardingsphere/pull/16642#discussion_r845772900
##########
docs/blog/content/material/proxyIntroduce.cn.md:
##########
@@ -0,0 +1,377 @@
++++
+title = "ShardingSphere-Proxy：从实际场景出发，快速上手"
+weight = 26
Review Comment:
The weight is duplicated with an existed article. Could you find the maximum weight in current blogs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #16642: Add an introductory article on ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #16642:
URL: https://github.com/apache/shardingsphere/pull/16642#issuecomment-1093070323
@longtai-cn Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] longtai-cn commented on a diff in pull request #16642: Add an introductory article on ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
longtai-cn commented on code in PR #16642:
URL: https://github.com/apache/shardingsphere/pull/16642#discussion_r845775872
##########
docs/blog/content/material/proxyIntroduce.cn.md:
##########
@@ -0,0 +1,377 @@
++++
+title = "ShardingSphere-Proxy：从实际场景出发，快速上手"
+weight = 26
Review Comment:
@TeslaCN In the Chinese blog, 《[Apache ShardingSphere 在京东白条场景的落地之旅](https://shardingsphere.apache.org/blog/cn/material/oct_12_9_shardingsphere_jd-baitiao_story_of_an_implementation_journey/)》 has a maximum weight of 25, which I added on this basis
-- Is it according to the maximum weight of Chinese blog or the overall weight of blog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] longtai-cn commented on a diff in pull request #16642: Add an introductory article on ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
longtai-cn commented on code in PR #16642:
URL: https://github.com/apache/shardingsphere/pull/16642#discussion_r845790367
##########
docs/blog/content/material/proxyIntroduce.cn.md:
##########
@@ -0,0 +1,377 @@
++++
+title = "ShardingSphere-Proxy：从实际场景出发，快速上手"
+weight = 26
Review Comment:
OK, I see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #16642: Add an introductory article on ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #16642:
URL: https://github.com/apache/shardingsphere/pull/16642#discussion_r845789678
##########
docs/blog/content/material/proxyIntroduce.cn.md:
##########
@@ -0,0 +1,377 @@
++++
+title = "ShardingSphere-Proxy：从实际场景出发，快速上手"
+weight = 26
Review Comment:
The weight shall be based on maximum of all blogs. Some articles may be translated into Chinese or English later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16642: Add an introductory article on ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16642:
URL: https://github.com/apache/shardingsphere/pull/16642#issuecomment-1093015686
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16642](https://codecov.io/gh/apache/shardingsphere/pull/16642?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a1cb92) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5aa2071bcb1d850b61b8e2b98ba77f2d12b683ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5aa2071) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16642 +/- ##
============================================
- Coverage 60.66% 60.56% -0.10%
- Complexity 2097 2115 +18
============================================
Files 3374 3382 +8
Lines 50775 50881 +106
Branches 8715 8733 +18
============================================
+ Hits 30802 30817 +15
- Misses 17383 17473 +90
- Partials 2590 2591 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16642?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rdingsphere/driver/state/lock/LockDriverState.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zdGF0ZS9sb2NrL0xvY2tEcml2ZXJTdGF0ZS5qYXZh) | `33.33% <0.00%> (-33.34%)` | :arrow_down: |
| [.../driver/state/circuit/CircuitBreakDriverState.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zdGF0ZS9jaXJjdWl0L0NpcmN1aXRCcmVha0RyaXZlclN0YXRlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [.../infra/metadata/schema/util/IndexMetaDataUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvdXRpbC9JbmRleE1ldGFEYXRhVXRpbC5qYXZh) | `16.66% <0.00%> (-20.84%)` | :arrow_down: |
| [...sphere/singletable/route/SingleTableSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvcm91dGUvU2luZ2xlVGFibGVTUUxSb3V0ZXIuamF2YQ==) | `62.06% <0.00%> (-6.51%)` | :arrow_down: |
| [...hardingsphere/spi/type/typed/TypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcGkvdHlwZS90eXBlZC9UeXBlZFNQSVJlZ2lzdHJ5LmphdmE=) | `92.59% <0.00%> (-3.57%)` | :arrow_down: |
| [...tatement/impl/OpenGaussDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3BlbmdhdXNzL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3BlbkdhdXNzRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `79.31% <0.00%> (-1.41%)` | :arrow_down: |
| [...atement/impl/PostgreSQLDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9Qb3N0Z3JlU1FMRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `80.72% <0.00%> (-1.29%)` | :arrow_down: |
| [...uery/ShowScalingCheckAlgorithmsQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1Nob3dTY2FsaW5nQ2hlY2tBbGdvcml0aG1zUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `86.66% <0.00%> (-0.84%)` | :arrow_down: |
| [...ate/CreateShardingScalingRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9DcmVhdGVTaGFyZGluZ1NjYWxpbmdSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `91.66% <0.00%> (-0.40%)` | :arrow_down: |
| [...phere/spi/type/singleton/SingletonSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcGkvdHlwZS9zaW5nbGV0b24vU2luZ2xldG9uU1BJUmVnaXN0cnkuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/shardingsphere/pull/16642/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16642?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16642?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5aa2071...0a1cb92](https://codecov.io/gh/apache/shardingsphere/pull/16642?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #16642: Add an introductory article on ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
TeslaCN merged PR #16642:
URL: https://github.com/apache/shardingsphere/pull/16642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org