[GitHub] [cordova-plugin-camera] erisu commented on a change in pull request #435: Update browser plugin

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #435: Update browser plugin
URL: https://github.com/apache/cordova-plugin-camera/pull/435#discussion_r273311623
 
 

 ##########
 File path: README.md
 ##########
 @@ -266,6 +266,10 @@ Optional parameters to customize the camera settings.
 | saveToPhotoAlbum | <code>Boolean</code> |  | Save the image to the photo album on the device after capture. |
 | popoverOptions | <code>[CameraPopoverOptions](#module_CameraPopoverOptions)</code> |  | iOS-only options that specify popover location in iPad. |
 | cameraDirection | <code>[Direction](#module_Camera.Direction)</code> | <code>BACK</code> | Choose the camera to use (front- or back-facing). |
+| customCameraContainer | <code>string</code> |  | Browser-only option, specify the id of custom camera's container element.  |
 
 Review comment:
   [1] IMO, I think it would be better if these new options accept either a `query` string or `DOMElement`.
   
   * `Query` string would give more flexibility in how the element is discovered vs an ID only. In this case, we would need to use the `document.querySelector` method instead of the `getElementById`.
   
   * `DOMElement` could also be a viable option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org