You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/11/22 13:43:00 UTC

[jira] [Work logged] (HIVE-26455) Remove PowerMockito from hive-exec

     [ https://issues.apache.org/jira/browse/HIVE-26455?focusedWorklogId=827997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827997 ]

ASF GitHub Bot logged work on HIVE-26455:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Nov/22 13:42
            Start Date: 22/Nov/22 13:42
    Worklog Time Spent: 10m 
      Work Description: InvisibleProgrammer opened a new pull request, #3798:
URL: https://github.com/apache/hive/pull/3798

   ### What changes were proposed in this pull request?
   
   PowerMockito is a mockito extension that introduces some painful points. 
   
   The main intention behind that is to be able to do static mocking. Since its release, mockito-inline has been released, as a part of the mockito-core. 
   It doesn't require vintage test runner to be able to run and it can mock objects with their own thread. 
   
   
   ### Why are the changes needed?
   PowerMock allows some crazy things that shouldn't be allowed. Like mocking constructors, and core libraries (like System package). 
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   I ran the affected tests manually on my local computer. And let the apache infrastructure to run all the tests on the PR. 
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 827997)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove PowerMockito from hive-exec
> ----------------------------------
>
>                 Key: HIVE-26455
>                 URL: https://issues.apache.org/jira/browse/HIVE-26455
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: Zsolt Miskolczi
>            Assignee: Zsolt Miskolczi
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> PowerMockito is a mockito extension that introduces some painful points. 
> The main intention behind that is to be able to do static mocking. Since its release, mockito-inline has been released, as a part of the mockito-core. 
> It doesn't require vintage test runner to be able to run and it can mock objects with their own thread. 
> The goal is to stop using PowerMockito and use mockito-inline instead.
>  
> The affected packages are: 
>  * org.apache.hadoop.hive.ql.exec.repl
>  * org.apache.hadoop.hive.ql.exec.repl.bootstrap.load
>  * org.apache.hadoop.hive.ql.exec.repl.ranger;
>  * org.apache.hadoop.hive.ql.exec.util
>  * org.apache.hadoop.hive.ql.parse.repl
>  * org.apache.hadoop.hive.ql.parse.repl.load.message
>  * org.apache.hadoop.hive.ql.parse.repl.metric
>  * org.apache.hadoop.hive.ql.txn.compactor
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)