[GitHub] [arrow] pitrou commented on a diff in pull request #34392: GH-34391: [C++] Future as-of-join-node hangs on distant times

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1196415767


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -782,6 +941,10 @@ class InputState {
   std::vector<Type::type> key_type_id_;
   // Hasher for key elements
   mutable KeyHasher* key_hasher_;
+  // Owning node
+  AsofJoinNode& node_;

Review Comment:
   We want to avoid mutable references, as per the C++ style guide. References should be const, otherwise use a pointer to make it clear at the call site that the argument may be mutated.
   ```suggestion
     AsofJoinNode* node_;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org