You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2026/05/21 12:57:59 UTC
[PR] Revert gcsio 3 upgrades [beam]
Abacn opened a new pull request, #38583:
URL: https://github.com/apache/beam/pull/38583
**Please** add a meaningful description for your change here
It is found in DataflowTemplates release validation that staging Dataflow artifacts encountering a JUL bug JDK-8349206: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/3833#issuecomment-4502649406
Likely due to gcsio 3 added added signidicantly more fluent log logging. There is a risk of deadlock in high concurrency scenarios
Considering this risk and we are in progress of migrating off bigdataoss/gcsio, revert this upgrade for now. As a result IcebergIO's gcs-hadoop-connector (as well as Hadoop version) upgrade then needs to be done after the bigdataoss/gcsio migration.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert gcsio 3 upgrades [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38583:
URL: https://github.com/apache/beam/pull/38583#issuecomment-4508470730
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request reverts recent upgrades to gcsio (3.x) to mitigate deadlock risks and address stability concerns identified during release validation. The changes include downgrading the bigdataoss library version, updating build configurations to remove obsolete dependency pins, and adding defensive coding via reflection in GcsUtilV1 to handle connector construction safely. These adjustments stabilize the current environment while the project continues its migration away from bigdataoss/gcsio.
### Highlights
* **Reversion of gcsio Upgrades**: Reverted the upgrade of gcsio to version 3.x due to identified deadlock risks and compatibility issues with Java logging in high-concurrency scenarios.
* **Dependency Management Adjustments**: Downgraded google_cloud_bigdataoss_version to 2.2.26 and updated related Hadoop connector dependencies to ensure stability while migration efforts are ongoing.
* **GcsUtilV1 Compatibility**: Implemented reflection-based construction for GoogleCloudStorageImpl to maintain compatibility with older versions of the GCS connector while preparing for future upgrades.
* **Build Configuration Cleanup**: Removed outdated Hadoop version pins and adjusted Iceberg runtime dependencies to improve build reliability and support Java 11+ environments.
<details>
<summary><b>New Features</b></summary>
🧠You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert gcsio 3 upgrades [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38583:
URL: https://github.com/apache/beam/pull/38583#discussion_r3281312875
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV1.java:
##########
@@ -265,12 +267,8 @@ public boolean shouldRetry(IOException e) {
.setReadChannelOptions(gcsReadOptions)
.setGrpcEnabled(shouldUseGrpc)
.build();
- try {
- googleCloudStorage =
- createGoogleCloudStorage(googleCloudStorageOptions, storageClient, credentials);
- } catch (IOException e) {
- throw new RuntimeException(e);
- }
+ googleCloudStorage =
+ createGoogleCloudStorage(googleCloudStorageOptions, storageClient, credentials);
Review Comment:
The `createGoogleCloudStorage` method still needs to handle or declare `IOException` because the `GoogleCloudStorageImpl` constructor in `gcsio` 2.x throws it. The try-catch block should be restored here to maintain proper error handling and ensure the code compiles.
```java
try {
googleCloudStorage =
createGoogleCloudStorage(googleCloudStorageOptions, storageClient, credentials);
} catch (IOException e) {
throw new RuntimeException(e);
}
```
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV1.java:
##########
@@ -727,16 +725,48 @@ public WritableByteChannel create(GcsPath path, CreateOptions options) throws IO
}
GoogleCloudStorage createGoogleCloudStorage(
- GoogleCloudStorageOptions options, Storage storage, Credentials credentials)
- throws IOException {
- return GoogleCloudStorageImpl.builder()
- .setOptions(options)
- .setHttpTransport(storage.getRequestFactory().getTransport())
- .setCredentials(credentials)
- // gcsio 3 expects httpRequestInitializer to be either absent or
- // com.google.cloud.hadoop.util.RetryHttpInitializer when credentials not provided
- .setHttpRequestInitializer(credentials != null ? httpRequestInitializer : null)
- .build();
+ GoogleCloudStorageOptions options, Storage storage, Credentials credentials) {
+ try {
+ return new GoogleCloudStorageImpl(options, storage, credentials);
+ } catch (NoSuchMethodError e) {
+ // gcs-connector 3.x drops the direct constructor and exclusively uses Builder
+ // TODO eliminate reflection once Beam drops Java 8 support and upgrades to gcsio 3.x
+ try {
+ final Method builderMethod = GoogleCloudStorageImpl.class.getMethod("builder");
+ Object builder = builderMethod.invoke(null);
+ final Class<?> builderClass =
+ Class.forName(
+ "com.google.cloud.hadoop.gcsio.AutoBuilder_GoogleCloudStorageImpl_Builder");
+
+ final Method setOptionsMethod =
+ builderClass.getMethod("setOptions", GoogleCloudStorageOptions.class);
+ setOptionsMethod.setAccessible(true);
+ builder = setOptionsMethod.invoke(builder, options);
+
+ final Method setHttpTransportMethod =
+ builderClass.getMethod("setHttpTransport", HttpTransport.class);
+ setHttpTransportMethod.setAccessible(true);
+ builder =
+ setHttpTransportMethod.invoke(builder, storage.getRequestFactory().getTransport());
+
+ final Method setCredentialsMethod =
+ builderClass.getMethod("setCredentials", Credentials.class);
+ setCredentialsMethod.setAccessible(true);
+ builder = setCredentialsMethod.invoke(builder, credentials);
+
+ final Method setHttpRequestInitializerMethod =
+ builderClass.getMethod("setHttpRequestInitializer", HttpRequestInitializer.class);
+ setHttpRequestInitializerMethod.setAccessible(true);
+ builder = setHttpRequestInitializerMethod.invoke(builder, httpRequestInitializer);
Review Comment:
The reflection logic for `gcsio` 3.x should preserve the original behavior of passing `null` for the `httpRequestInitializer` when `credentials` are null. This was specifically required for `gcsio` 3.x as noted in the previous implementation's comments.
```suggestion
final Method setHttpRequestInitializerMethod =
builderClass.getMethod("setHttpRequestInitializer", HttpRequestInitializer.class);
setHttpRequestInitializerMethod.setAccessible(true);
builder = setHttpRequestInitializerMethod.invoke(
builder, credentials != null ? httpRequestInitializer : null);
```
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV1.java:
##########
@@ -727,16 +725,48 @@ public WritableByteChannel create(GcsPath path, CreateOptions options) throws IO
}
GoogleCloudStorage createGoogleCloudStorage(
- GoogleCloudStorageOptions options, Storage storage, Credentials credentials)
- throws IOException {
- return GoogleCloudStorageImpl.builder()
- .setOptions(options)
- .setHttpTransport(storage.getRequestFactory().getTransport())
- .setCredentials(credentials)
- // gcsio 3 expects httpRequestInitializer to be either absent or
- // com.google.cloud.hadoop.util.RetryHttpInitializer when credentials not provided
- .setHttpRequestInitializer(credentials != null ? httpRequestInitializer : null)
- .build();
+ GoogleCloudStorageOptions options, Storage storage, Credentials credentials) {
+ try {
+ return new GoogleCloudStorageImpl(options, storage, credentials);
+ } catch (NoSuchMethodError e) {
+ // gcs-connector 3.x drops the direct constructor and exclusively uses Builder
+ // TODO eliminate reflection once Beam drops Java 8 support and upgrades to gcsio 3.x
+ try {
+ final Method builderMethod = GoogleCloudStorageImpl.class.getMethod("builder");
+ Object builder = builderMethod.invoke(null);
+ final Class<?> builderClass =
+ Class.forName(
+ "com.google.cloud.hadoop.gcsio.AutoBuilder_GoogleCloudStorageImpl_Builder");
Review Comment:
Hardcoding the internal `AutoBuilder` class name is fragile and depends on implementation details of the `gcsio` library. It is safer to obtain the class directly from the builder instance returned by `GoogleCloudStorageImpl.builder()`.
```suggestion
final Class<?> builderClass = builder.getClass();
```
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV1.java:
##########
@@ -727,16 +725,48 @@ public WritableByteChannel create(GcsPath path, CreateOptions options) throws IO
}
GoogleCloudStorage createGoogleCloudStorage(
- GoogleCloudStorageOptions options, Storage storage, Credentials credentials)
- throws IOException {
- return GoogleCloudStorageImpl.builder()
- .setOptions(options)
- .setHttpTransport(storage.getRequestFactory().getTransport())
- .setCredentials(credentials)
- // gcsio 3 expects httpRequestInitializer to be either absent or
- // com.google.cloud.hadoop.util.RetryHttpInitializer when credentials not provided
- .setHttpRequestInitializer(credentials != null ? httpRequestInitializer : null)
- .build();
+ GoogleCloudStorageOptions options, Storage storage, Credentials credentials) {
Review Comment:
The `GoogleCloudStorageImpl` constructor in `gcsio` 2.x throws a checked `IOException`. Removing `throws IOException` from this method signature will cause a compilation error when using the 2.x library. Please restore the exception declaration.
```java
GoogleCloudStorage createGoogleCloudStorage(
GoogleCloudStorageOptions options, Storage storage, Credentials credentials)
throws IOException {
```
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergScanConfig.java:
##########
@@ -19,7 +19,7 @@
import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull;
-import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Sets.newHashSet;
+import static org.apache.hadoop.util.Sets.newHashSet;
Review Comment:
Beam prefers using its vendored Guava dependencies (`org.apache.beam.vendor.guava...`) over external utility classes like `org.apache.hadoop.util.Sets` to ensure classpath stability and avoid version conflicts with user-provided Hadoop environments.
```suggestion
import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Sets.newHashSet;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert gcsio 3 upgrades [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn closed pull request #38583: Revert gcsio 3 upgrades
URL: https://github.com/apache/beam/pull/38583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org