You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/26 08:07:46 UTC

[GitHub] [superset] ecederstrand opened a new pull request, #21586: chore(dep): Unpin slackclient dependency

ecederstrand opened a new pull request, #21586:
URL: https://github.com/apache/superset/pull/21586

   SUMMARY
   
   This is the last of three PRs, attempting to unpin Superset dependencies. See also https://github.com/apache/superset/pull/21581 and https://github.com/apache/superset/pull/21091
   
   `slackclient` was originally pinned in https://github.com/apache/superset/pull/10345 due to https://github.com/slackapi/python-slack-sdk/issues/728 which was fixed in a series of PRs concluding with https://github.com/slackapi/python-slack-sdk/issues/901 which was released in `slack_sdk` version 3.1.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on pull request #21586: chore(dep): Unpin slackclient dependency

Posted by GitBox <gi...@apache.org>.
villebro commented on PR #21586:
URL: https://github.com/apache/superset/pull/21586#issuecomment-1257812372

   Tagging @dpgaspar and @bkyryliuk for additional reviews to validate for potential regressions caused by the Slack client major bump.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #21586: chore(dep): Unpin slackclient dependency

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21586:
URL: https://github.com/apache/superset/pull/21586#issuecomment-1257815063

   # [Codecov](https://codecov.io/gh/apache/superset/pull/21586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21586](https://codecov.io/gh/apache/superset/pull/21586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1da5238) into [master](https://codecov.io/gh/apache/superset/commit/5d51555c464eef2a9a4e95485f3830319a72f0cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d51555) will **decrease** coverage by `1.47%`.
   > The diff coverage is `40.00%`.
   
   > :exclamation: Current head 1da5238 differs from pull request most recent head 53f21a7. Consider uploading reports for the commit 53f21a7 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #21586      +/-   ##
   ==========================================
   - Coverage   66.65%   65.18%   -1.48%     
   ==========================================
     Files        1794     1794              
     Lines       68692    68692              
     Branches     7308     7308              
   ==========================================
   - Hits        45789    44776    -1013     
   - Misses      21035    22048    +1013     
     Partials     1868     1868              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `78.28% <40.00%> (ø)` | |
   | presto | `?` | |
   | python | `78.37% <40.00%> (-3.05%)` | :arrow_down: |
   | sqlite | `76.78% <40.00%> (ø)` | |
   | unit | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/21586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `88.00% <100.00%> (ø)` | |
   | [superset/tables/schemas.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFibGVzL3NjaGVtYXMucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset/columns/schemas.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29sdW1ucy9zY2hlbWFzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
   | [...set/advanced\_data\_type/plugins/internet\_address.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfYWRkcmVzcy5weQ==) | `16.32% <0.00%> (-79.60%)` | :arrow_down: |
   | [superset/utils/pandas\_postprocessing/boxplot.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2JveHBsb3QucHk=) | `20.51% <0.00%> (-79.49%)` | :arrow_down: |
   | [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `11.76% <0.00%> (-77.95%)` | :arrow_down: |
   | [...perset/advanced\_data\_type/plugins/internet\_port.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfcG9ydC5weQ==) | `18.75% <0.00%> (-77.09%)` | :arrow_down: |
   | [superset/utils/pandas\_postprocessing/rolling.py](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3JvbGxpbmcucHk=) | `21.87% <0.00%> (-68.75%)` | :arrow_down: |
   | ... and [54 more](https://codecov.io/gh/apache/superset/pull/21586/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on a diff in pull request #21586: chore(dep): Unpin slackclient dependency

Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #21586:
URL: https://github.com/apache/superset/pull/21586#discussion_r979898683


##########
setup.py:
##########
@@ -94,7 +94,7 @@ def get_git_sha() -> str:
         "graphlib-backport",
         "gunicorn>=20.1.0",
         "hashids>=1.3.1, <2",
-        "holidays==0.14.2",
+        "holidays>=0.14.2",

Review Comment:
   While we're at it, should we bring this one up to the current version also?
   ```suggestion
           "holidays>=0.16.0, <0.17",
   ```
   The changelog looks pretty straight forward, and I kind of like the added support for 3.11 in 0.15 which we'll soon start working towards: https://github.com/dr-prodigy/python-holidays/blob/master/CHANGES



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on a diff in pull request #21586: chore(dep): Unpin slackclient dependency

Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #21586:
URL: https://github.com/apache/superset/pull/21586#discussion_r979823622


##########
setup.py:
##########
@@ -114,11 +114,11 @@ def get_git_sha() -> str:
         "redis",
         "selenium>=3.141.0",
         "simplejson>=3.15.0",
-        "slackclient==2.5.0",  # PINNED! slack changes file upload api in the future versions
+        "slack_sdk>=3.1.1",
         "sqlalchemy>=1.4, <2",
         "sqlalchemy-utils>=0.38.3, <0.39",
         "sqlparse==0.3.0",  # PINNED! see https://github.com/andialbrecht/sqlparse/issues/562
-        "tabulate==0.8.9",
+        "tabulate>=0.8.9",

Review Comment:
   ..and here something similar, assuming typical semver?
   ```suggestion
           "tabulate>=0.8.9, <0.9",
   ```



##########
setup.py:
##########
@@ -114,11 +114,11 @@ def get_git_sha() -> str:
         "redis",
         "selenium>=3.141.0",
         "simplejson>=3.15.0",
-        "slackclient==2.5.0",  # PINNED! slack changes file upload api in the future versions
+        "slack_sdk>=3.1.1",

Review Comment:
   Can we add a `,4` here, just in case?
   ```suggestion
           "slack_sdk>=3.1.1, <4",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on a diff in pull request #21586: chore(dep): Unpin slackclient dependency

Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #21586:
URL: https://github.com/apache/superset/pull/21586#discussion_r979823051


##########
setup.py:
##########
@@ -114,11 +114,11 @@ def get_git_sha() -> str:
         "redis",
         "selenium>=3.141.0",
         "simplejson>=3.15.0",
-        "slackclient==2.5.0",  # PINNED! slack changes file upload api in the future versions
+        "slack_sdk>=3.1.1",

Review Comment:
   Can we add a `, <4` here, just in case?
   ```suggestion
           "slack_sdk>=3.1.1, <4",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org