You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Aman Sinha <as...@maprtech.com> on 2014/03/17 20:06:08 UTC
Re: Review Request 18388: Drill 381 - Options statements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18388/#review37429
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
<https://reviews.apache.org/r/18388/#comment68952>
It wasn't clear whether the drillOptions in the plan properties contains all the options or just the ones set specifically in the session. I would assume that it is the latter ..such that if there are say total 100 options but the session is explicitly setting 2 of them, we don't need to propagate the default values of all 100 through each plan. Is that the case ?
- Aman Sinha
On Feb. 22, 2014, 12:44 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18388/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 12:44 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/DRILL-381
>
> This patch creates adds a storage system for Drill options. Currently only the session options are working correctly.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/logical/PlanProperties.java 5980bf8
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java 875e8b6
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 256e772
> exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java 6e58ec7
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java ec7244a
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 2e2d7fd
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OptionValueReader.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OptionValueReaderBatch.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OptionValueReaderCreator.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java 0f45dbe
> exec/java-exec/src/main/java/org/apache/drill/exec/server/DistributedGlobalOptions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillOptions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 6400c75
> exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java 39821e3
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java e4f8e7b
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java 2dd8611
> exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java PRE-CREATION
> exec/java-exec/src/test/resources/server/options_session_check.json PRE-CREATION
> exec/java-exec/src/test/resources/server/options_set.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Altekruse
>
>
Re: Review Request 18388: Drill 381 - Options statements
Posted by Jason Altekruse <al...@gmail.com>.
> On March 17, 2014, 7:06 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java, line 201
> > <https://reviews.apache.org/r/18388/diff/1/?file=500792#file500792line201>
> >
> > It wasn't clear whether the drillOptions in the plan properties contains all the options or just the ones set specifically in the session. I would assume that it is the latter ..such that if there are say total 100 options but the session is explicitly setting 2 of them, we don't need to propagate the default values of all 100 through each plan. Is that the case ?
The plan properties contains any modifications to either the session or global options that should be changed before the plan is executed. Global options still need a small change to the distributed cache, this should be completed this week, but the interface for setting global options has already been added. I will add to the google doc for drill syntax. Below is and example:
options : {
session : {
"EXPLAIN_PLAN_LEVEL" : "PHYSICAL"
},
global : {
"ALLOW_QUOTED_IDENTIFIERS" : "ON"
}
}
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18388/#review37429
-----------------------------------------------------------
On Feb. 22, 2014, 12:44 a.m., Jason Altekruse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18388/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 12:44 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/DRILL-381
>
> This patch creates adds a storage system for Drill options. Currently only the session options are working correctly.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/logical/PlanProperties.java 5980bf8
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java 875e8b6
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 256e772
> exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java 6e58ec7
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java ec7244a
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 2e2d7fd
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OptionValueReader.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OptionValueReaderBatch.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OptionValueReaderCreator.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java 0f45dbe
> exec/java-exec/src/main/java/org/apache/drill/exec/server/DistributedGlobalOptions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillOptions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 6400c75
> exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java 39821e3
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java e4f8e7b
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java 2dd8611
> exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java PRE-CREATION
> exec/java-exec/src/test/resources/server/options_session_check.json PRE-CREATION
> exec/java-exec/src/test/resources/server/options_set.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Altekruse
>
>