You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Jean-Louis MONTEIRO <je...@atosorigin.com> on 2009/05/08 22:30:20 UTC

Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Jacek,

You're right, the file is not on SVN.
It should be located in
openejb/trunk/openejb3/examples/simple-webservice/src/main/resources/org/superbiz/handler/handler.xml

I forgot to add it in the first patch. Jon already faces this problem that's
why I changed the patch file (OPENEJB-1001). Jon is aware of that, so I
think he hasn't got any time to apply the patch again.

Sorry for that.
Jean-Louis



Jacek Laskowski wrote:
> 
> On Tue, May 5, 2009 at 11:46 PM,  <jg...@apache.org> wrote:
>> Author: jgallimore
>> Date: Tue May  5 21:46:37 2009
>> New Revision: 771980
>>
>> URL: http://svn.apache.org/viewvc?rev=771980&view=rev
>> Log:
>> OPENEJB-1001 soap header patch from Jean-Louis Monteiro
> ...
>> Modified:
>> openejb/trunk/openejb3/examples/simple-webservice/src/main/java/org/superbiz/calculator/CalculatorImpl.java
>> URL:
>> http://svn.apache.org/viewvc/openejb/trunk/openejb3/examples/simple-webservice/src/main/java/org/superbiz/calculator/CalculatorImpl.java?rev=771980&r1=771979&r2=771980&view=diff
>> ==============================================================================
>> ---
>> openejb/trunk/openejb3/examples/simple-webservice/src/main/java/org/superbiz/calculator/CalculatorImpl.java
>> (original)
>> +++
>> openejb/trunk/openejb3/examples/simple-webservice/src/main/java/org/superbiz/calculator/CalculatorImpl.java
>> Tue May  5 21:46:37 2009
>> @@ -16,8 +16,12 @@
>>  */
>>  package org.superbiz.calculator;
>>
>> +import java.util.Date;
>> +
>>  import javax.ejb.Stateless;
>> +import javax.jws.HandlerChain;
>>  import javax.jws.WebService;
>> +import javax.xml.ws.Holder;
>>
>>  /**
>>  * This is an EJB 3 style pojo stateless session bean
>> @@ -32,6 +36,7 @@
>>         serviceName = "CalculatorWsService",
>>         targetNamespace = "http://superbiz.org/wsdl",
>>         endpointInterface = "org.superbiz.calculator.CalculatorWs")
>> +@HandlerChain(file = "handler.xml")
>>  public class CalculatorImpl implements CalculatorWs, CalculatorLocal {
> 
> Hi,
> 
> I'm trying to build the latest sources and it fails with the following
> exception (in examples\simple-webservice):
> 
> WARN - Jar not loaded. classpath.ear.  Unable to load handler chain
> file: handler.xml: null
> org.apache.openejb.OpenEJBException: Unable to load handler chain
> file: handler.xml: null
>         at
> org.apache.openejb.config.WsDeployer.getHandlerChains(WsDeployer.java:445)
> ...
> Caused by: java.lang.NullPointerException
>         at
> org.apache.openejb.config.ReadDescriptors.readHandlerChains(ReadDescriptors.java:431)
>         at
> org.apache.openejb.config.WsDeployer.getHandlerChains(WsDeployer.java:443)
>         ... 42 more
> 
> The NPE is just a side effect of a missing handler.xml file. I'm
> investigating it, but would appreciate some advice for easy fixing.
> Dunno how the file should look like and what it should contains.
> 
> Jacek
> 
> -- 
> Jacek Laskowski
> Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
> 
> 

-- 
View this message in context: http://www.nabble.com/Re%3A-svn-commit%3A-r771980---in--openejb-trunk-openejb3%3A--examples-simple-webservice-src-main-java-org-superbiz-calculator---examples-simple-webservice-src-main-java-org-superbiz-handler---examples-simple-webservice-src-test-java-org-superbiz-calculator--s-tp23437507p23452012.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.


Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jean-Louis MONTEIRO <je...@atosorigin.com>.


Jean-Louis MONTEIRO wrote:
> 
> It's my fault because I added another sample to highlight another bug
> related with SOAP faults when there is no handler (OPENEJB-965). And when
> I created the patch, I choose the bad xml handler file.
> 

I will try to repackage ASAP another sample for faults so may be you will be
able either to apply my proposed patch or to create another one.


Jean-Louis

-- 
View this message in context: http://www.nabble.com/Re%3A-svn-commit%3A-r771980---in--openejb-trunk-openejb3%3A--examples-simple-webservice-src-main-java-org-superbiz-calculator---examples-simple-webservice-src-main-java-org-superbiz-handler---examples-simple-webservice-src-test-java-org-superbiz-calculator--s-tp23437507p23504009.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.


Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On Tue, May 12, 2009 at 3:38 PM, Jean-Louis MONTEIRO
<je...@atosorigin.com> wrote:

> @Jacek, as far as I can see in the org.superbiz.calculator.CalculatorImpl
> SVN history, you removed the @HandlerChain(file = "handler.xml") annotation.
>
> @Jacek/@Jon: can you put again this annotation and move the handler.xml file
> to the right package ?

Doing it now.

Jacek

-- 
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl

Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On Tue, May 12, 2009 at 3:38 PM, Jean-Louis MONTEIRO
<je...@atosorigin.com> wrote:

> @Jacek, as far as I can see in the org.superbiz.calculator.CalculatorImpl
> SVN history, you removed the @HandlerChain(file = "handler.xml") annotation.
>
> @Jacek/@Jon: can you put again this annotation and move the handler.xml file
> to the right package ?

Done. Keep the ws-security-related samples coming - I'm learning while fixing :)

jlaskowski@work /cygdrive/c/oss/openejb3/examples
$ svn ci -m 'Handler added and unecessary permission tags when
fork=true removed' .
Sending        examples/simple-webservice/src/main/java/org/superbiz/calculator/CalculatorImpl.java
Adding         examples/simple-webservice/src/main/resources/org/superbiz/calculator
Adding         examples/simple-webservice/src/main/resources/org/superbiz/calculator/handler.xml
Deleting       examples/simple-webservice/src/main/resources/org/superbiz/handler
Sending        examples/webservice-ws-security/pom.xml
Transmitting file data ..
Committed revision 773937.

Jacek

-- 
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl

Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jean-Louis MONTEIRO <je...@atosorigin.com>.
Jon,

You are not alone. Because, the handler file is not located in the right
package.
It should be located in the same package as the implementation:
org.superbiz.calculator
and not org.superbiz.handler

It's my fault because I added another sample to highlight another bug
related with SOAP faults when there is no handler (OPENEJB-965). And when I
created the patch, I choose the bad xml handler file.

@Jacek, as far as I can see in the org.superbiz.calculator.CalculatorImpl
SVN history, you removed the @HandlerChain(file = "handler.xml") annotation.

@Jacek/@Jon: can you put again this annotation and move the handler.xml file
to the right package ?

Thanks in advance and sorry for that troubles.

Jean-Louis






Jonathan Gallimore-2 wrote:
> 
> Sorry this my fault, I forgot the 'svn add' when I applied Jean-Louis'
> patch. It should be there now.
> 
> Jon
> 

-- 
View this message in context: http://www.nabble.com/Re%3A-svn-commit%3A-r771980---in--openejb-trunk-openejb3%3A--examples-simple-webservice-src-main-java-org-superbiz-calculator---examples-simple-webservice-src-main-java-org-superbiz-handler---examples-simple-webservice-src-test-java-org-superbiz-calculator--s-tp23437507p23502780.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.


Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jonathan Gallimore <jo...@gmail.com>.
Sorry this my fault, I forgot the 'svn add' when I applied Jean-Louis'
patch. It should be there now.

Jon

On Mon, May 11, 2009 at 1:59 PM, Jacek Laskowski <ja...@laskowski.net.pl>wrote:

> On Mon, May 11, 2009 at 1:44 PM, Jean-Louis MONTEIRO
> <je...@atosorigin.com> wrote:
> >
> > I've the same error and stacktrace but the test fails.
> ...
> > So yes if you specify an handler, you must provide the target xml file.
>
> Could you check it out now with the latest sources? I've fixed them
> and all should build without any troubles. I'm on Cygwin with Java 6
> and Maven 2.0.9.
>
> Jacek
>
> --
> Jacek Laskowski
> Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
>

Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On Mon, May 11, 2009 at 1:44 PM, Jean-Louis MONTEIRO
<je...@atosorigin.com> wrote:
>
> I've the same error and stacktrace but the test fails.
...
> So yes if you specify an handler, you must provide the target xml file.

Could you check it out now with the latest sources? I've fixed them
and all should build without any troubles. I'm on Cygwin with Java 6
and Maven 2.0.9.

Jacek

-- 
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl

Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jean-Louis MONTEIRO <je...@atosorigin.com>.
I've the same error and stacktrace but the test fails.


Caused by: java.lang.NullPointerException
        at
org.apache.openejb.config.ReadDescriptors.readHandlerChains(ReadDescriptors.java:431)
        at
org.apache.openejb.config.WsDeployer.getHandlerChains(WsDeployer.java:429)
        ... 42 more
INFO - Starting network services
  ** Starting Services **
  NAME                 IP              PORT
  httpejbd             127.0.0.1       4204
  admin thread         127.0.0.1       4200
  ejbd                 127.0.0.1       4201
-------
Ready!
[Fatal Error] CalculatorImpl?wsdl:1:1: Premature end of file.
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.391 sec
<<< FAILURE!

So yes if you specify an handler, you must provide the target xml file.

Jean-Louis



Jacek Laskowski wrote:
> 
> On Fri, May 8, 2009 at 10:30 PM, Jean-Louis MONTEIRO
> <je...@atosorigin.com> wrote:
> 
>> It should be located in
>> openejb/trunk/openejb3/examples/simple-webservice/src/main/resources/org/superbiz/handler/handler.xml
>>
>> I forgot to add it in the first patch. Jon already faces this problem
>> that's
>> why I changed the patch file (OPENEJB-1001). Jon is aware of that, so I
>> think he hasn't got any time to apply the patch again.
> 
> Is it still necessary? The test passes without it. Why was it needed
> in the first place?
> 
> Jacek
> 
> -- 
> Jacek Laskowski
> Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
> 
> 

-- 
View this message in context: http://www.nabble.com/Re%3A-svn-commit%3A-r771980---in--openejb-trunk-openejb3%3A--examples-simple-webservice-src-main-java-org-superbiz-calculator---examples-simple-webservice-src-main-java-org-superbiz-handler---examples-simple-webservice-src-test-java-org-superbiz-calculator--s-tp23437507p23481705.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.


Re: svn commit: r771980 - in /openejb/trunk/openejb3: examples/simple-webservice/src/main/java/org/superbiz/calculator/ examples/simple-webservice/src/main/java/org/superbiz/handler/ examples/simple-webservice/src/test/java/org/superbiz/calculator/ s

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On Fri, May 8, 2009 at 10:30 PM, Jean-Louis MONTEIRO
<je...@atosorigin.com> wrote:

> It should be located in
> openejb/trunk/openejb3/examples/simple-webservice/src/main/resources/org/superbiz/handler/handler.xml
>
> I forgot to add it in the first patch. Jon already faces this problem that's
> why I changed the patch file (OPENEJB-1001). Jon is aware of that, so I
> think he hasn't got any time to apply the patch again.

Is it still necessary? The test passes without it. Why was it needed
in the first place?

Jacek

-- 
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl