You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/09/02 11:25:10 UTC

[GitHub] [hudi] leesf commented on a change in pull request #2059: [HUDI-1254] TypedProperties can not get values by initializing an existing properties

leesf commented on a change in pull request #2059:
URL: https://github.com/apache/hudi/pull/2059#discussion_r481995336



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/TypedProperties.java
##########
@@ -37,10 +38,12 @@ public TypedProperties(Properties defaults) {
     super(defaults);
   }
 
-  private void checkKey(String property) {
-    if (!containsKey(property)) {
+  private boolean checkKey(String property) {

Review comment:
       `checkKey` would be rename to `containsKey`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org