You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/29 11:41:56 UTC
[GitHub] [superset] przemyslawandruszewski opened a new pull request #17888: Add possibility to use configured Service Account Name for init job.
przemyslawandruszewski opened a new pull request #17888:
URL: https://github.com/apache/superset/pull/17888
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Possibility to use Service Account Name by ini-job.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
`helm install superset .`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1002598420
> Ok, so I will add your changes to my PR. Sure feel free to add your suggestions, all feedback is welcome :)
after this one: https://github.com/apache/superset/pull/17886 is merged. so rebase from master and get that fix in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 edited a comment on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
wiktor2200 edited a comment on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1004863664
Thanks a lot for help and co-op!
I've missed typo in my PR, already fixed it in #17920 (wating for CR and merge). I'm mentioning it here to inform you on current progress. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] przemyslawandruszewski commented on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
przemyslawandruszewski commented on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1002573405
Hey @wiktor2200, Sure I have just quickly looked at your PR so it looks nice, I will have maybe 1/2 suggestions so if you are OK, let's merge the changes? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a change in pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #17888:
URL: https://github.com/apache/superset/pull/17888#discussion_r777125194
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -31,6 +31,9 @@ spec:
{{ toYaml .Values.init.podAnnotations | nindent 8 }}
{{- end }}
spec:
+ {{- if .Values.serviceAccountName }}
Review comment:
Can you add a default value, with a comment around it in the `values.yaml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] przemyslawandruszewski commented on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
przemyslawandruszewski commented on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1002565617
Hi @craig-rueda! Could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] przemyslawandruszewski closed pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
przemyslawandruszewski closed pull request #17888:
URL: https://github.com/apache/superset/pull/17888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1002575612
Ok, so I will add your changes to my PR. Sure feel free to add your suggestions, all feedback is welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1002568571
Could you please take a look on my PR and issue?
PR: https://github.com/apache/superset/pull/17880
issue: https://github.com/apache/superset/issues/17879
I've extended this feature (added service account creation if needed and added helpers for managing multiple conditions).
If you want, I can add your PR to mine, so custom service account will be available everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1004863664
Thanks a lot for help and co-op!
I've missed typo in my PR, already fixed it in #17920. I'm mentioning it here to inform you on current progress. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] przemyslawandruszewski commented on pull request #17888: Add possibility to use configured Service Account Name for init job.
Posted by GitBox <gi...@apache.org>.
przemyslawandruszewski commented on pull request #17888:
URL: https://github.com/apache/superset/pull/17888#issuecomment-1004850809
I can see that @wiktor2200 got his PR #17880 merged so I will close this one. Thanks a lot for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org