[jira] [Commented] (AMBARI-24768) Load Upgrade Checks Dynamically From Stacks

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-24768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651910#comment-16651910 ] 

Hudson commented on AMBARI-24768:
---------------------------------

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10214 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10214/])
[AMBARI-24768] - Load Upgrade Checks Dynamically From Stacks (#2451) (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=6f2622c76d63a49f9bf06cb062b939836a8a96b7])
* (edit) ambari-server/docs/configuration/index.md
* (edit) ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java
* (add) ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistryProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/stack/upgrade/orchestrate/UpgradeHelper.java
* (add) ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeTypeQualificationTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java
* (add) ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeTypeQualification.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeCheckOrderTest.java
* (edit) ambari-server-spi/src/main/java/org/apache/ambari/annotations/UpgradeCheckInfo.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/stack/upgrade/UpgradePack.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java
* (edit) ambari-server-spi/src/main/java/org/apache/ambari/spi/upgrade/UpgradeCheck.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ClusterCheckTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java


> Load Upgrade Checks Dynamically From Stacks
> -------------------------------------------
>
>                 Key: AMBARI-24768
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24768
>             Project: Ambari
>          Issue Type: Task
>    Affects Versions: 2.8.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 2.8.0
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Stack-provided upgrade checks need to be loaded from a provided JAR when Ambari Server starts up. Currently, upgrade checks are loaded synchronously, scanning the entire classpath for classes matching {{UpgradeCheck}} in the package {{org.apache.ambari.server.checks}}. This can be extremely slow and cause Ambari Server to fail to start within a reasonable amount of time. The proposed changes for this issue are as follows: 
> - Move to an asynchronous model for scanning the classpath for instances of {{UpgradeCheck}}
> - Allow stacks to provide their own plugin directory & JAR for loading SPI implementations of {{UpgradeCheck}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)