You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/07/20 18:30:32 UTC
[GitHub] [incubator-mxnet] RafLit opened a new pull request #20463: add include sorting for mkldnn files
RafLit opened a new pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463
## Description ##
This PR is a followup to #20356 and includes further code formatting changes.
- added includes flagged by cpplint
- sorted the includes with clang-format
The clang-format config used for formatting:
```
---
Language: Cpp
BasedOnStyle: Google
ColumnLimit: 100
AlignConsecutiveAssignments: true
AlignConsecutiveDeclarations: false
AlignConsecutiveMacros: true
DerivePointerAlignment: false
SortIncludes: true
MaxEmptyLinesToKeep: 1
PointerAlignment: Left
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Empty
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: true
BinPackArguments: false
BinPackParameters: false
SortIncludes: true
IncludeBlocks: Regroup
IncludeCategories:
# Headers in <> from specific external libraries.
- Regex: '<((mxnet)|(nnvm)|(dmlc)|(gtest))\/([-\/_A-Za-z0-9])+((\.h)|(\.hpp))>'
Priority: 1
# Headers in <> with extension.
- Regex: '<([-\/_A-Za-z0-9])+((\.h)|(\.hpp))>'
Priority: 2
# Headers in <> without extension.
- Regex: '<([-\/_A-Za-z0-9])+>'
Priority: 3
# Local (./) Headers in "" with extension.
- Regex: '"(\.\/)([-\/_A-Za-z0-9])+((\.h)|(\.hpp))"'
Priority: 4
# Local (../) Headers in "" with extension.
- Regex: '"(\.\.\/)+([-\/_A-Za-z0-9])+((\.h)|(\.hpp))"'
Priority: 5
# Headers in "" with extension.
- Regex: '"([-\/_A-Za-z0-9])+((\.h)|(\.hpp))"'
Priority: 6
```
In this PR I formatted the following files:
- src/operator/nn/mkldnn/* (for mkldnn_batch_dot-inl.h only the include sorting)
- src/operator/quantization/mkldnn/*
- src/operator/subgraph/mkldnn/*
- tests/cpp/include/test_mkldnn.h (only the include sorting)
- tests/cpp/operator/mkldnn_operator_test.cc
- tests/cpp/operator/mkldnn_test.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-889808978
Jenkins CI successfully triggered : [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit closed pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit closed pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-884727638
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-889808941
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-885484639
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-887268288
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-887268359
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-886429037
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-888637151
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit closed pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
RafLit closed pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-888637195
Jenkins CI successfully triggered : [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20463: add include sorting for mkldnn files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20463:
URL: https://github.com/apache/incubator-mxnet/pull/20463#issuecomment-883606034
Hey @RafLit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, sanity, centos-gpu, miscellaneous, windows-gpu, website, unix-gpu, windows-cpu, centos-cpu, unix-cpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org