[GitHub] jihoonson commented on a change in pull request #6698: do not watch unwanted tier's data node in HttpServerInventoryView

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #6698: do not watch unwanted tier's data node in HttpServerInventoryView
URL: https://github.com/apache/incubator-druid/pull/6698#discussion_r240470529
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/HttpServerInventoryView.java
 ##########
 @@ -390,6 +390,10 @@ private void serverAdded(DruidServer server)
     synchronized (servers) {
       DruidServerHolder holder = servers.get(server.getName());
       if (holder == null) {
+        if (!finalPredicate.apply(Pair.of(server.getMetadata(), null))) {
 
 Review comment:
   This makes `rhs` of the predicate argument nullable now, but I believe nullable argument can make things complicated. How about adding a new interface like `registerSegmentCallback(Executor exec, SegmentCallback callback, Predicate<DruidServerMetadata> predicate)` to `FilteredServerInventoryView`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org