You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/11 11:15:51 UTC

[GitHub] [spark] liucht-inspur opened a new pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

liucht-inspur opened a new pull request #30335:
URL: https://github.com/apache/spark/pull/30335


   **What changes were proposed in this pull request?**
   Limit the height of the menu area on the left to display vertical scroll bar
   
   **Why are the changes needed?**
   
   The bottom menu item cannot be displayed when the left menu tree is long
   
   **Does this PR introduce any user-facing change?**
   
   Yes, if the menu item shows more, you'll see it by pulling down the vertical scroll bar
   
   before:
   ![image](https://user-images.githubusercontent.com/28332082/98805115-16995d80-2452-11eb-933a-3b72c14bea78.png)
   
   after:
   ![image](https://user-images.githubusercontent.com/28332082/98805159-20bb5c00-2452-11eb-8154-9dbdb1d031bf.png)
   
   **How was this patch tested?**
   NA
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liucht-inspur commented on a change in pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r524844885



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;

Review comment:
       Okļ¼ŒThanks @HyukjinKwon and @srowen , I will submit the code separately as a fix for the next issues.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725447176


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35541/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725380048


   **[Test build #130935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130935/testReport)** for PR 30335 at commit [`31996a1`](https://github.com/apache/spark/commit/31996a1ded0e953924d3357cd7c461a4096cfa1c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725431749


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35541/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-731165722


   Okay, at least it looks better.
   
   Merged to master and branch-3.0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r521832211



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;

Review comment:
       Since we're here, shall we batch `left-menu.width` to 210 px too? That makes the subtitles look truncated. I don't know why we made that longer specifically (https://github.com/apache/spark/pull/25459/files#r521829348).
   
   And, actually we should make the width itself more wider. I would suggest to make it 280px. cc @gatorsmile and @dilipbiswal 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725775513


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35559/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725447213






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725383655


   I've checked it manually and the change seems fine. cc: @HyukjinKwon @gatorsmile @huaxingao 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725385155


   **[Test build #130935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130935/testReport)** for PR 30335 at commit [`31996a1`](https://github.com/apache/spark/commit/31996a1ded0e953924d3357cd7c461a4096cfa1c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729544457


   **[Test build #131275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131275/testReport)** for PR 30335 at commit [`5dee41d`](https://github.com/apache/spark/commit/5dee41db7848760d5542335b1e1e0d383c8564c9).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729551045






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725755287


   **[Test build #130953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130953/testReport)** for PR 30335 at commit [`0dff48a`](https://github.com/apache/spark/commit/0dff48a9412c7acc08cc106a2a2646aba06455c6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-731165917


   Thanks for your contribution @liucht-inspur.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725385312






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729645420


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725380048


   **[Test build #130935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130935/testReport)** for PR 30335 at commit [`31996a1`](https://github.com/apache/spark/commit/31996a1ded0e953924d3357cd7c461a4096cfa1c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725366331


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725765783






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r524824100



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;

Review comment:
       That's fine. Can be separately done. but I think we should still fix https://github.com/apache/spark/pull/30335#discussion_r521831406.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725785562






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liucht-inspur commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-728786197


   cc @HyukjinKwon @srowen @maropu @huaxingao 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725385312






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liucht-inspur commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729546908


   Hi @HyukjinKwon I have finished the repair, please help to review,thanks!
   before:
   ![image](https://user-images.githubusercontent.com/28332082/99510275-d42bcf80-29c1-11eb-86be-cd1e3eeaae01.png)
   ![image](https://user-images.githubusercontent.com/28332082/99510305-dd1ca100-29c1-11eb-8857-ff26375888f6.png)
   after:
   ![image](https://user-images.githubusercontent.com/28332082/99510375-f887ac00-29c1-11eb-84ae-79fb0bf3dca3.png)
   ![image](https://user-images.githubusercontent.com/28332082/99510442-0b01e580-29c2-11eb-9074-a0d5b3791fc6.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729550858


   **[Test build #131275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131275/testReport)** for PR 30335 at commit [`5dee41d`](https://github.com/apache/spark/commit/5dee41db7848760d5542335b1e1e0d383c8564c9).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725785542


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35559/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725366867


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725378641


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729645428


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35879/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725765667


   **[Test build #130953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130953/testReport)** for PR 30335 at commit [`0dff48a`](https://github.com/apache/spark/commit/0dff48a9412c7acc08cc106a2a2646aba06455c6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r521831406



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;
+  height: 80%;

Review comment:
       Looks like it wouldn't work properly when the side bar is folded:
   
   Before:
   
   ![Screen Shot 2020-11-12 at 1 24 49 PM](https://user-images.githubusercontent.com/6477701/98895470-88bd8100-24ea-11eb-80f0-7307a71ec3b5.png)
   
   
   After:
   
   ![Screen Shot 2020-11-12 at 1 24 53 PM](https://user-images.githubusercontent.com/6477701/98895477-8c510800-24ea-11eb-92d1-534c865acbe4.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725785562






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725366867


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729632908


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35879/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725447213






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729551055






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on a change in pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r521711970



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;
+  height:80%;

Review comment:
       extremely nit: add a space after `:`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725765783






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729544457


   **[Test build #131275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131275/testReport)** for PR 30335 at commit [`5dee41d`](https://github.com/apache/spark/commit/5dee41db7848760d5542335b1e1e0d383c8564c9).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liucht-inspur commented on a change in pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r521866229



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;

Review comment:
       Hi @HyukjinKwon  As I modified, the horizontal scrollbar can be displayed and used after setting the height to 80%
   after:
   ![image](https://user-images.githubusercontent.com/28332082/98903795-3e8ccd80-24f3-11eb-8ecf-6b0ad334bcb3.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r521831751



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;
+  height: 80%;

Review comment:
       also the end of bat does not seem matching:
   ![Screen Shot 2020-11-12 at 1 26 30 PM](https://user-images.githubusercontent.com/6477701/98895733-b9051f80-24ea-11eb-8aea-248a9053b580.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on a change in pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #30335:
URL: https://github.com/apache/spark/pull/30335#discussion_r524350479



##########
File path: docs/css/main.css
##########
@@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; }
   border-bottom-width: 0px;
   margin-top: 0px;
   width: 210px;

Review comment:
       How does that sound @HyukjinKwon 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725366331


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729645397


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35879/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30335: [SPARK-33422][SQL][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-725755287


   **[Test build #130953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130953/testReport)** for PR 30335 at commit [`0dff48a`](https://github.com/apache/spark/commit/0dff48a9412c7acc08cc106a2a2646aba06455c6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30335:
URL: https://github.com/apache/spark/pull/30335


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729645420






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liucht-inspur commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-730814197


   cc @HyukjinKwon @srowen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #30335: [SPARK-33422][DOC] Fix the correct display of left menu item

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30335:
URL: https://github.com/apache/spark/pull/30335#issuecomment-729339845


   @liucht-inspur, can you try what I mentioned in https://github.com/apache/spark/pull/30335#discussion_r521831406? After this change, it looks a bit odds when it's folded.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org