[GitHub] [cassandra] jonmeredith commented on a change in pull request #698: CASSANDRA-15980 - Improved log messaging for socket connection/disconnection

[GitBox <gi...@apache.org>]

jonmeredith commented on a change in pull request #698:
URL: https://github.com/apache/cassandra/pull/698#discussion_r463329196



##########
File path: src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
##########
@@ -445,11 +454,11 @@ void setupMessagingPipeline(InetAddressAndPort from, int useMessagingVersion, in
             InboundMessageHandler handler =
                 settings.handlers.apply(from).createHandler(frameDecoder, initiate.type, pipeline.channel(), useMessagingVersion);
 
-            logger.info("{} connection established, version = {}, framing = {}, encryption = {}",
+            logger.info("{} messaging connection established, version = {}, framing = {}, encryption = {}",

Review comment:
       It's to disambiguate between streaming connections so I'd prefer to keep it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org