You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Remko Popma (JIRA)" <ji...@apache.org> on 2013/12/23 15:58:50 UTC
[jira] [Resolved] (LOG4J2-455) RingBufferLogEvent should use
Messsage timestamp first
[ https://issues.apache.org/jira/browse/LOG4J2-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Remko Popma resolved LOG4J2-455.
--------------------------------
Resolution: Fixed
Assignee: Remko Popma
Fixed in revision 1553122.
Please verify and close.
> RingBufferLogEvent should use Messsage timestamp first
> ------------------------------------------------------
>
> Key: LOG4J2-455
> URL: https://issues.apache.org/jira/browse/LOG4J2-455
> Project: Log4j 2
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 2.0-beta9
> Reporter: robin zhang tao
> Assignee: Remko Popma
>
> When AsyncLogger received log message (method
> {code}
> public void log(final Marker marker, final String fqcn, final Level level, final Message data,
> final Throwable t)
> {code}
> ), currently it uses
> {code}
> clock.currentTimeMillis()
> {code}
> (see at Line 221) as the timestamp.
> But it should check the message implements TimestampMessage or not, if yes, should use TimestampMessage.getTimestamp() as the timestamp, if not , then using clock.currentTimeMillis().
> The new Code:
> {code}
> data instanceof TimestampMessage ? ((TimestampMessage) data ).getTimestamp() : clock.currentTimeMillis();
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org