You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "TenYearsIn (via GitHub)" <gi...@apache.org> on 2023/03/20 10:18:09 UTC
[GitHub] [apisix] TenYearsIn opened a new pull request, #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
TenYearsIn opened a new pull request, #9115:
URL: https://github.com/apache/apisix/pull/9115
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes #8996
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] TenYearsIn commented on pull request #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
Posted by "TenYearsIn (via GitHub)" <gi...@apache.org>.
TenYearsIn commented on PR #9115:
URL: https://github.com/apache/apisix/pull/9115#issuecomment-1706431742
> @TenYearsIn, I can add test cases here if you add me as a collaborator in your apisix forked repository.
>
> https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-access-to-your-personal-repositories/inviting-collaborators-to-a-personal-repository
Let me try again. if not. do so @shreemaan-abhishek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9115: feat: traffic-split plugin support https
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9115:
URL: https://github.com/apache/apisix/pull/9115#discussion_r1338139262
##########
t/plugin/traffic-split2.t:
##########
@@ -799,3 +799,75 @@ GET /t
--- error_code: 500
--- error_log
failed to find upstream by id: invalid-id
+
+
+
+=== TEST 21: use upstream with https scheme
Review Comment:
The test case can pass without your pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9115:
URL: https://github.com/apache/apisix/pull/9115#issuecomment-1706390178
@TenYearsIn, I can add test cases here if you add me as a collaborator in your apisix forked repository.
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-access-to-your-personal-repositories/inviting-collaborators-to-a-personal-repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #9115: feat: traffic-split plugin support https
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #9115:
URL: https://github.com/apache/apisix/pull/9115#discussion_r1338305604
##########
t/plugin/traffic-split2.t:
##########
@@ -799,3 +799,75 @@ GET /t
--- error_code: 500
--- error_log
failed to find upstream by id: invalid-id
+
+
+
+=== TEST 21: use upstream with https scheme
Review Comment:
looks like using `upstream_id` supports https but using real upstream is not supported, I have pushed my changes now, please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9115:
URL: https://github.com/apache/apisix/pull/9115#issuecomment-1706589078
@TenYearsIn, please provide access to me to your forked repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] TenYearsIn commented on pull request #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
Posted by "TenYearsIn (via GitHub)" <gi...@apache.org>.
TenYearsIn commented on PR #9115:
URL: https://github.com/apache/apisix/pull/9115#issuecomment-1493379484
The Test case (traffic-split2.t) 11 seems that there was some problem, I used the original code to test it, but it still fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] TenYearsIn commented on pull request #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
Posted by "TenYearsIn (via GitHub)" <gi...@apache.org>.
TenYearsIn commented on PR #9115:
URL: https://github.com/apache/apisix/pull/9115#issuecomment-1706676519
@shreemaan-abhishek done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9115:
URL: https://github.com/apache/apisix/pull/9115#issuecomment-1488331793
Hi @TenYearsIn, test cases are needed and please make the ci pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 merged pull request #9115: feat: traffic-split plugin support https
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #9115:
URL: https://github.com/apache/apisix/pull/9115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #9115: feat: traffic-split plugin can't proxy virtual upstream that schema is https
Posted by "soulbird (via GitHub)" <gi...@apache.org>.
soulbird commented on PR #9115:
URL: https://github.com/apache/apisix/pull/9115#issuecomment-1493545748
Without your modification, I can also run the test case through.
In general, adding new functionality should not change existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org