[GitHub] [accumulo] keith-turner commented on a change in pull request #1105: Issue-1104_DocumentAndTestKeyConstructorsForCopyBehavior updated java…

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1105: Issue-1104_DocumentAndTestKeyConstructorsForCopyBehavior updated java…
URL: https://github.com/apache/accumulo/pull/1105#discussion_r276662825
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/data/Key.java
 ##########
 @@ -119,7 +119,10 @@ public Key() {
 
   /**
    * Creates a key with the specified row, empty column family, empty column qualifier, empty column
-   * visibility, timestamp {@link Long#MAX_VALUE}, and delete marker false.
+   * visibility, timestamp {@link Long#MAX_VALUE}, and delete marker false.  This constructor creates
+   * a copy of row. If you don't want to create a copy of row, you should call
 
 Review comment:
   Could be made a bit shorter w/o loss of information.  Something like :
   
   ```
   To avoid copying, use {@link Key#Key(byte[] row, byte[] cf, byte[] cq, byte[] cv, long ts, boolean deleted, boolean copy)}.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services