You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2016/11/16 21:46:23 UTC
Fwd: [1/2] [lang] LANG-1285: NullPointerException in
FastDateParser$TimeZoneStrategy (closes #212)
More for us to pick up?
Gary
---------- Forwarded message ----------
From: <pa...@apache.org>
Date: Wed, Nov 16, 2016 at 12:46 PM
Subject: [1/2] [lang] LANG-1285: NullPointerException in
FastDateParser$TimeZoneStrategy (closes #212)
To: commits@commons.apache.org
Repository: commons-lang
Updated Branches:
refs/heads/master fd80301b1 -> 8bac0be03
LANG-1285: NullPointerException in FastDateParser$TimeZoneStrategy (closes
#212)
Replicate the fix for LANG-1186
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/c14890f0
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/c14890f0
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/c14890f0
Branch: refs/heads/master
Commit: c14890f08b9bb47ab8ad27f4dd4c714e32961d0d
Parents: fd80301
Author: Francesco Chicchiriccò <il...@apache.org>
Authored: Wed Nov 16 07:07:43 2016 +0100
Committer: pascalschumacher <pa...@gmx.net>
Committed: Wed Nov 16 21:44:41 2016 +0100
----------------------------------------------------------------------
.../org/apache/commons/lang3/time/FastDateParser.java | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/
c14890f0/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
index 2729c7a..a9470d3 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
@@ -866,11 +866,13 @@ public class FastDateParser implements DateParser,
Serializable {
tzInfo = standard;
break;
}
- final String key = zoneNames[i].toLowerCase(locale);
- // ignore the data associated with duplicates supplied
in
- // the additional names
- if (sorted.add(key)) {
- tzNames.put(key, tzInfo);
+ if (zoneNames[i] != null) {
+ final String key = zoneNames[i].toLowerCase(
locale);
+ // ignore the data associated with duplicates
supplied in
+ // the additional names
+ if (sorted.add(key)) {
+ tzNames.put(key, tzInfo);
+ }
}
}
}
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [1/2] [lang] LANG-1285: NullPointerException in
FastDateParser$TimeZoneStrategy (closes #212)
Posted by Matt Sicker <bo...@gmail.com>.
Looks like it.
On 16 November 2016 at 15:46, Gary Gregory <ga...@gmail.com> wrote:
> More for us to pick up?
>
> Gary
>
> ---------- Forwarded message ----------
> From: <pa...@apache.org>
> Date: Wed, Nov 16, 2016 at 12:46 PM
> Subject: [1/2] [lang] LANG-1285: NullPointerException in FastDateParser$TimeZoneStrategy
> (closes #212)
> To: commits@commons.apache.org
>
>
> Repository: commons-lang
> Updated Branches:
> refs/heads/master fd80301b1 -> 8bac0be03
>
>
> LANG-1285: NullPointerException in FastDateParser$TimeZoneStrategy
> (closes #212)
>
> Replicate the fix for LANG-1186
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/c
> 14890f0
> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/c14890f0
> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/c14890f0
>
> Branch: refs/heads/master
> Commit: c14890f08b9bb47ab8ad27f4dd4c714e32961d0d
> Parents: fd80301
> Author: Francesco Chicchiriccò <il...@apache.org>
> Authored: Wed Nov 16 07:07:43 2016 +0100
> Committer: pascalschumacher <pa...@gmx.net>
> Committed: Wed Nov 16 21:44:41 2016 +0100
>
> ----------------------------------------------------------------------
> .../org/apache/commons/lang3/time/FastDateParser.java | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/c14
> 890f0/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> ----------------------------------------------------------------------
> diff --git a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> index 2729c7a..a9470d3 100644
> --- a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> +++ b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> @@ -866,11 +866,13 @@ public class FastDateParser implements DateParser,
> Serializable {
> tzInfo = standard;
> break;
> }
> - final String key = zoneNames[i].toLowerCase(locale);
> - // ignore the data associated with duplicates
> supplied in
> - // the additional names
> - if (sorted.add(key)) {
> - tzNames.put(key, tzInfo);
> + if (zoneNames[i] != null) {
> + final String key = zoneNames[i].toLowerCase(local
> e);
> + // ignore the data associated with duplicates
> supplied in
> + // the additional names
> + if (sorted.add(key)) {
> + tzNames.put(key, tzInfo);
> + }
> }
> }
> }
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Matt Sicker <bo...@gmail.com>