You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/09/27 02:00:30 UTC
[GitHub] [hadoop] DadanielZ commented on a change in pull request #1481:
HADOOP-16587: Made auth endpoints configurable for MSI and refresh token
flows
DadanielZ commented on a change in pull request #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows
URL: https://github.com/apache/hadoop/pull/1481#discussion_r328888536
##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/AzureADAuthenticator.java
##########
@@ -109,15 +112,12 @@ public static AzureADToken getTokenUsingClientCreds(String authEndpoint,
* @return {@link AzureADToken} obtained using the creds
* @throws IOException throws IOException if there is a failure in obtaining the token
*/
- public static AzureADToken getTokenFromMsi(String tenantGuid, String clientId,
+ public static AzureADToken getTokenFromMsi(final String authEndpoint, String tenantGuid, String clientId,
Review comment:
since you are adding `final`, could you also update the other params? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org