You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "rangareddy (via GitHub)" <gi...@apache.org> on 2024/09/11 04:52:24 UTC

Re: [PR] [531] xtable poms are missing license details. [incubator-xtable]

rangareddy commented on code in PR #533:
URL: https://github.com/apache/incubator-xtable/pull/533#discussion_r1751986481


##########
pom.xml:
##########
@@ -19,19 +19,32 @@
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache</groupId>
+        <artifactId>apache</artifactId>
+        <version>33</version>
+    </parent>
 
     <groupId>org.apache.xtable</groupId>
     <artifactId>xtable</artifactId>
-    <name>xtable</name>
+    <name>XTable Parent Project</name>

Review Comment:
   It will displays the project name clearly while building the xtable. You can refer [Spark](https://github.com/apache/spark/blob/master/pom.xml#L31) code for reference. 
   
   ```sh
   [INFO] XTable Parent Project .............................. SUCCESS [  0.316 s]
   [INFO] XTable Api Project ................................. SUCCESS [  0.032 s]
   [INFO] XTable Hudi Support Parent Project ................. SUCCESS [  0.025 s]
   [INFO] XTable Hudi Support Utils Project .................. SUCCESS [  0.019 s]
   [INFO] XTable Core Project ................................ SUCCESS [  0.036 s]
   [INFO] XTable Utilities Project ........................... SUCCESS [  0.014 s]
   [INFO] XTable Hudi Support Extensions Project ............. SUCCESS [  0.015 s]
   [INFO] ------------------------------------------------------------------------
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org