[GitHub] [flink] twalthr commented on a change in pull request #11651: [FLINK-16995][table-common] Add new data structure interfaces in table-common

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #11651: [FLINK-16995][table-common] Add new data structure interfaces in table-common
URL: https://github.com/apache/flink/pull/11651#discussion_r408020465
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/StringData.java
 ##########
 @@ -23,43 +23,48 @@
 import org.apache.flink.table.types.logical.VarCharType;
 
 /**
- * {@link StringData} is an internal data structure represents data of {@link VarCharType}
- * and {@link CharType} in Flink Table/SQL.
+ * An internal data structure representing data of {@link CharType} and {@link VarCharType}.
+ *
+ * <p>This data structure is immutable.
 
 Review comment:
   @wuchong What I meant with immutable is that it does not provide any setters. Because `GenericRowData` has setters. But I'm fine with removing it here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services