You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2021/12/21 01:50:20 UTC
[pinot] branch master updated: Add instance id in response (#7937)
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 03e8fcb Add instance id in response (#7937)
03e8fcb is described below
commit 03e8fcba4e7154fadc77a4a104cf1b6ad9661ce9
Author: Jialiang Li <jl...@linkedin.com>
AuthorDate: Mon Dec 20 17:49:59 2021 -0800
Add instance id in response (#7937)
Co-authored-by: Jack Li(Analytics Engineering) <jl...@jlli-mn1.linkedin.biz>
---
.../pinot/core/query/executor/ServerQueryExecutorV1Impl.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java b/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
index ca07815..c0a0ab3 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
@@ -145,9 +145,9 @@ public class ServerQueryExecutorV1Impl implements QueryExecutor {
long querySchedulingTimeMs = System.currentTimeMillis() - queryArrivalTimeMs;
if (querySchedulingTimeMs >= queryTimeoutMs) {
_serverMetrics.addMeteredTableValue(tableNameWithType, ServerMeter.SCHEDULING_TIMEOUT_EXCEPTIONS, 1);
- String errorMessage =
- String.format("Query scheduling took %dms (longer than query timeout of %dms)", querySchedulingTimeMs,
- queryTimeoutMs);
+ String errorMessage = String
+ .format("Query scheduling took %dms (longer than query timeout of %dms) on server: %s", querySchedulingTimeMs,
+ queryTimeoutMs, _instanceDataManager.getInstanceId());
DataTable dataTable = DataTableBuilder.getEmptyDataTable();
dataTable.addException(QueryException.getException(QueryException.QUERY_SCHEDULING_TIMEOUT_ERROR, errorMessage));
LOGGER.error("{} while processing requestId: {}", errorMessage, requestId);
@@ -156,7 +156,8 @@ public class ServerQueryExecutorV1Impl implements QueryExecutor {
TableDataManager tableDataManager = _instanceDataManager.getTableDataManager(tableNameWithType);
if (tableDataManager == null) {
- String errorMessage = "Failed to find table: " + tableNameWithType;
+ String errorMessage = String
+ .format("Failed to find table: %s on server: %s", tableNameWithType, _instanceDataManager.getInstanceId());
DataTable dataTable = DataTableBuilder.getEmptyDataTable();
dataTable.addException(QueryException.getException(QueryException.SERVER_TABLE_MISSING_ERROR, errorMessage));
LOGGER.error("{} while processing requestId: {}", errorMessage, requestId);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org