You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitt10prashant <gi...@git.apache.org> on 2015/07/14 11:39:43 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/585
CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limit…
test result
========
Test Try to deploy VM with admin account where account has not used ... === TestName: test_01_deploy_vm_domain_limit_reached | Status : SUCCESS ===
ok
Test Try to deploy VM with admin account where account has used ... === TestName: test_02_deploy_vm_account_limit_reached | Status : SUCCESS ===
ok
Test TTry to deploy VM with admin account where account has not used ... === TestName: test_03_deploy_vm_project_limit_reached | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 440.349s
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitt10prashant/cloudstack ss_mx_limits
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/585.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #585
----
commit 6d8cf3109195a896f2161a02f20d9401a3a67683
Author: nitt10prashant <ni...@gmail.com>
Date: 2015-07-14T09:38:58Z
CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limits.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/585#issuecomment-121210527
its there in ticket
On Tue, Jul 14, 2015 at 5:03 PM, sanju1010 <no...@github.com> wrote:
> Can you please specify the reason for changing the if condition for the
> benefit of others?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/585#issuecomment-121210285>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition to...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/585#issuecomment-121522610
thanks LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if
condition in...
Posted by Sanjeev N <sa...@apache.org>.
LGTM!!
On Tue, Jul 14, 2015 at 5:08 PM, DaanHoogland <gi...@git.apache.org> wrote:
> Github user DaanHoogland commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/585#issuecomment-121211124
>
> I agree with Sanju. please ammend to something like
> CLOUDSTACK-8631: changing if condition to update to zero when needed
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/585#issuecomment-121211124
I agree with Sanju. please ammend to something like
CLOUDSTACK-8631: changing if condition to update to zero when needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/585#issuecomment-121210285
Can you please specify the reason for changing the if condition for the benefit of others?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---