You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Radim Kolar (JIRA)" <ji...@apache.org> on 2012/10/22 17:58:13 UTC
[jira] [Created] (YARN-178) Fix custom ProcessTree instance
creation
Radim Kolar created YARN-178:
--------------------------------
Summary: Fix custom ProcessTree instance creation
Key: YARN-178
URL: https://issues.apache.org/jira/browse/YARN-178
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 3.0.0, 0.23.5
Reporter: Radim Kolar
Priority: Critical
Attachments: pstree-instance.txt
1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
2. pstree do not extend Configured as it should
Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482184#comment-13482184 ]
Radim Kolar commented on YARN-178:
----------------------------------
you need to know root pid of process tree to construct it. base class is not using it because its abstract
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Radim Kolar updated YARN-178:
-----------------------------
Attachment: pstree-instance.txt
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482432#comment-13482432 ]
Robert Joseph Evans commented on YARN-178:
------------------------------------------
I am fine with either setting it through a contructor or through a setter method. I agree with Radim that the constructor makes it more obvious that it is not supposed to change, but other places tend to use setter methods instead, like with Configuration which is also not supposed to change.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484097#comment-13484097 ]
Hudson commented on YARN-178:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #1206 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1206/])
YARN-178. Fix custom ProcessTree instance creation (Radim Kolar via bobby) (Revision 1401698)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401698
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481493#comment-13481493 ]
Hadoop QA commented on YARN-178:
--------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550307/pstree-instance.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-YARN-Build/110//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/110//console
This message is automatically generated.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482917#comment-13482917 ]
Bikas Saha commented on YARN-178:
---------------------------------
Sure. Please go ahead.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Radim Kolar updated YARN-178:
-----------------------------
Attachment: pstree-instance2.txt
reformated tabs to spaces, rethrow an exception during instance creation
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483262#comment-13483262 ]
Hudson commented on YARN-178:
-----------------------------
Integrated in Hadoop-trunk-Commit #2921 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2921/])
YARN-178. Fix custom ProcessTree instance creation (Radim Kolar via bobby) (Revision 1401698)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401698
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481494#comment-13481494 ]
Robert Joseph Evans commented on YARN-178:
------------------------------------------
Oh I didn't notice this before, but the test file has '\t' tab characters in it. Could you reformat it to remove the tabs and have it correspond to the two spaces per indentation?
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482256#comment-13482256 ]
Radim Kolar commented on YARN-178:
----------------------------------
you need constructor which is shared by all subclasses. Alternatively, it could be method instead of constructor but because root process pid do not change then constructor is better.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482457#comment-13482457 ]
Radim Kolar commented on YARN-178:
----------------------------------
let patch be as it is. current code is using constructor for linux variant.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482068#comment-13482068 ]
Bikas Saha commented on YARN-178:
---------------------------------
The change looks reasonable. What is not clear is why this is being made? Nothing seems to use the pid in the base class nor is there any other code that uses it.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482247#comment-13482247 ]
Bikas Saha commented on YARN-178:
---------------------------------
Then why add it to the constructor of the abstract base class?
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484081#comment-13484081 ]
Hudson commented on YARN-178:
-----------------------------
Integrated in Hadoop-Hdfs-0.23-Build #415 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/415/])
YARN-178. Fix custom ProcessTree instance creation (Radim Kolar via bobby) (Revision 1401701)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401701
Files :
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481492#comment-13481492 ]
Robert Joseph Evans commented on YARN-178:
------------------------------------------
I have one small issue with the patch. In RefelctionUtils.newInstance when it catches an exception it wraps it in a RuntimeException and then throws it, this patch will instead output a small log message. I would prefer to see it do the same thing as reflectionUtils for compatibility reasons. Other then that the patch looks good to me.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482491#comment-13482491 ]
Robert Joseph Evans commented on YARN-178:
------------------------------------------
Makes since. Bikas, unless you have a strong objection I will check this in this afternoon.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Radim Kolar reassigned YARN-178:
--------------------------------
Assignee: Radim Kolar
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483248#comment-13483248 ]
Robert Joseph Evans commented on YARN-178:
------------------------------------------
Sorry I got distracted by other things. Checking this in now.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482621#comment-13482621 ]
Hadoop QA commented on YARN-178:
--------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550313/pstree-instance2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-YARN-Build/122//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/122//console
This message is automatically generated.
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484038#comment-13484038 ]
Hudson commented on YARN-178:
-----------------------------
Integrated in Hadoop-Yarn-trunk #16 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/16/])
YARN-178. Fix custom ProcessTree instance creation (Radim Kolar via bobby) (Revision 1401698)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401698
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481527#comment-13481527 ]
Radim Kolar commented on YARN-178:
----------------------------------
i need this to be merged into branch-0.23 as well
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-178) Fix custom ProcessTree instance
creation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484138#comment-13484138 ]
Hudson commented on YARN-178:
-----------------------------
Integrated in Hadoop-Mapreduce-trunk #1236 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1236/])
YARN-178. Fix custom ProcessTree instance creation (Radim Kolar via bobby) (Revision 1401698)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401698
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
> Key: YARN-178
> URL: https://issues.apache.org/jira/browse/YARN-178
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0, 0.23.5
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Critical
> Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
> Attachments: pstree-instance2.txt, pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly configured.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira