You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/14 17:38:43 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #2498: feat(github): return relevent status inside body when return login
warren830 opened a new pull request, #2498:
URL: https://github.com/apache/incubator-devlake/pull/2498
closes #2497
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing](https://devlake.apache.org/community/) Documentation & [PR Template](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [ ] This PR is using a `label` (bug, feature etc.)
- [ ] My code is has necessary documentation (if appropriate)
- [ ] I have added any relevant tests
- [ ] This section (**⚠️ Pre Checklist**) will be removed when submitting PR
# Summary
For github test connection, as described in #2497 , we add `success` and `message` into the body if it succeeds.
### Does this close any open issues?
closes #2497
### Screenshots
<img width="498" alt="image" src="https://user-images.githubusercontent.com/39366025/179047507-7ae0d6b6-2213-41fb-b2ce-1b3462f7035f.png">
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] hezyin merged pull request #2498: feat(github): return relevent status inside body when return login
Posted by GitBox <gi...@apache.org>.
hezyin merged PR #2498:
URL: https://github.com/apache/incubator-devlake/pull/2498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on pull request #2498: feat(github): return relevent status inside body when return login
Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #2498:
URL: https://github.com/apache/incubator-devlake/pull/2498#issuecomment-1184805332
I also tested this to verify.
Previously:
Now:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org