You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/03/03 16:28:51 UTC
Review Request 18688: when pushing a large config file (like log4j),
don't show all content in log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18688/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-4917
https://issues.apache.org/jira/browse/AMBARI-4917
Repository: ambari
Description
-------
Update a Service config that has log4j properties (for example, Hive). On restart when the configs are pushed, all the log4j content is in the log. This is a lot to show. Long messages should be truncated
Diffs
-----
ambari-agent/src/main/python/resource_management/core/logger.py a22cd86
Diff: https://reviews.apache.org/r/18688/diff/
Testing
-------
OK
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [0.076s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.026s]
[INFO] Ambari Web ........................................ SUCCESS [8.260s]
[INFO] Ambari Views ...................................... SUCCESS [1.809s]
[INFO] Ambari Server ..................................... SUCCESS [11:01.252s]
[INFO] Ambari Agent ...................................... SUCCESS [13.244s]
[INFO] Ambari Client ..................................... SUCCESS [0.412s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 18688: when pushing a large config file (like log4j),
don't show all content in log
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18688/#review35967
-----------------------------------------------------------
Let's skip the whole content not do truncate, since this kind of details would really distract user from the info he need to find. IMHO, we should show just the steps done.
Also the reson to this, is that showing 256 symbols is too much for us to show for one property, we want to make log small enough to feet info our heartbeats best.
- Andrew Onischuk
On March 3, 2014, 3:28 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18688/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 3:28 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-4917
> https://issues.apache.org/jira/browse/AMBARI-4917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update a Service config that has log4j properties (for example, Hive). On restart when the configs are pushed, all the log4j content is in the log. This is a lot to show. Long messages should be truncated
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/core/logger.py a22cd86
>
> Diff: https://reviews.apache.org/r/18688/diff/
>
>
> Testing
> -------
>
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [0.076s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.026s]
> [INFO] Ambari Web ........................................ SUCCESS [8.260s]
> [INFO] Ambari Views ...................................... SUCCESS [1.809s]
> [INFO] Ambari Server ..................................... SUCCESS [11:01.252s]
> [INFO] Ambari Agent ...................................... SUCCESS [13.244s]
> [INFO] Ambari Client ..................................... SUCCESS [0.412s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 18688: when pushing a large config file (like log4j),
don't show all content in log
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18688/#review35968
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On March 3, 2014, 3:42 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18688/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 3:42 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-4917
> https://issues.apache.org/jira/browse/AMBARI-4917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update a Service config that has log4j properties (for example, Hive). On restart when the configs are pushed, all the log4j content is in the log. This is a lot to show. Long messages should be truncated
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/core/logger.py a22cd86
>
> Diff: https://reviews.apache.org/r/18688/diff/
>
>
> Testing
> -------
>
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [0.076s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.026s]
> [INFO] Ambari Web ........................................ SUCCESS [8.260s]
> [INFO] Ambari Views ...................................... SUCCESS [1.809s]
> [INFO] Ambari Server ..................................... SUCCESS [11:01.252s]
> [INFO] Ambari Agent ...................................... SUCCESS [13.244s]
> [INFO] Ambari Client ..................................... SUCCESS [0.412s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 18688: when pushing a large config file (like log4j),
don't show all content in log
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18688/
-----------------------------------------------------------
(Updated March 3, 2014, 3:42 p.m.)
Review request for Ambari and Andrew Onischuk.
Changes
-------
Don't show even a part of the content. Replace it with ...
Bugs: AMBARI-4917
https://issues.apache.org/jira/browse/AMBARI-4917
Repository: ambari
Description
-------
Update a Service config that has log4j properties (for example, Hive). On restart when the configs are pushed, all the log4j content is in the log. This is a lot to show. Long messages should be truncated
Diffs (updated)
-----
ambari-agent/src/main/python/resource_management/core/logger.py a22cd86
Diff: https://reviews.apache.org/r/18688/diff/
Testing
-------
OK
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [0.076s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.026s]
[INFO] Ambari Web ........................................ SUCCESS [8.260s]
[INFO] Ambari Views ...................................... SUCCESS [1.809s]
[INFO] Ambari Server ..................................... SUCCESS [11:01.252s]
[INFO] Ambari Agent ...................................... SUCCESS [13.244s]
[INFO] Ambari Client ..................................... SUCCESS [0.412s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen